Improve LFS tests + fix lfs url refs + keep path upper/lowercase in db.

[sapk]

All in the title.

Fix #3101

[sapk]

Need dockhippie/golang#2

[sapk]

I need to setup a separate repo to not influence other repos tests since clone after will not work because the server is not really started and can't get file for lfs.

[codecov-io]

Codecov Report

Merging #3092 into master will increase coverage by 0.76%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #3092      +/-   ##
==========================================
+ Coverage   34.06%   34.82%   +0.76%     
==========================================
  Files         274      274              
  Lines       40026    40026              
==========================================
+ Hits        13636    13941     +305     
+ Misses      24455    24086     -369     
- Partials     1935     1999      +64

Impacted Files	Coverage Δ
routers/repo/view.go	25.41% <0%> (ø)	⬆️
modules/lfs/server.go	35.01% <100%> (+31.29%)	⬆️
models/lfs_lock.go	69.76% <100%> (ø)	⬆️
models/repo_list.go	65.62% <0%> (-1.57%)	⬇️
models/repo_indexer.go	48.54% <0%> (+0.48%)	⬆️
modules/auth/auth.go	52.51% <0%> (+2.79%)	⬆️
models/repo.go	41.28% <0%> (+2.94%)	⬆️
modules/process/manager.go	81.15% <0%> (+4.34%)	⬆️
modules/lfs/locks.go	52.08% <0%> (+4.68%)	⬆️
routers/api/v1/repo/repo.go	40.1% <0%> (+7.1%)	⬆️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aecfc56...3ec055e. Read the comment docs.

[strk]

LGTM

[lunny]

LGTM

[lunny]

CI failed.

[ethantkoenig]

One general comment is that there is a lot of repeated boilerplate (e.g. making commits, pushing). While it would be nice to consolidate, I'm guessing there are other tests with similar boilerplate, so it's probably best to do wide-scale refactoring in a separate PR.

[ethantkoenig]

nit: use the userPassword constant (also in 162).

[sapk]

@ethantkoenig Replaced with userPassword and yes some integration tests could be refactor (in another PR) and maybe we could use a lib in this case to generate random file to commit.

[lunny]

@sapk maybe you could force push once since the Drone just recovered.

[lafriks]

@sapk test failed

[lunny]

@sapk CI still failed because of fmt-check

[sapk]

@lunny I know but I fix it but drone keep to stay on that commit. I retry to start multiple time, squash the commit fixing fmt ... with no luck

[sapk]

@lafriks thx, but drone seems broken and block on an unrelated test since 1hour ...

[lafriks]

@sapk please submit backport to 1.3 branch this bug was just in master and not in 1.3.0, right?

[sapk]

@lafriks It should not be in 1.3

[sapk]

thx all for the help.