Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort repos in issues dashboard sidebar #3072

Merged
merged 3 commits into from
Dec 4, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Dec 3, 2017

Sort repos in the sidebar of the issues dashboard page. Previously, the order would vary each time the page (re)loaded (example below).

image
image

@codecov-io
Copy link

codecov-io commented Dec 3, 2017

Codecov Report

Merging #3072 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3072      +/-   ##
==========================================
- Coverage   33.28%   33.28%   -0.01%     
==========================================
  Files         273      273              
  Lines       39947    39954       +7     
==========================================
+ Hits        13297    13298       +1     
- Misses      24749    24761      +12     
+ Partials     1901     1895       -6
Impacted Files Coverage Δ
models/repo_list.go 67.18% <100%> (+1.61%) ⬆️
routers/user/home.go 41.59% <100%> (+0.17%) ⬆️
models/repo_indexer.go 49% <0%> (-2.98%) ⬇️
modules/indexer/repo.go 60.86% <0%> (-2.61%) ⬇️
models/repo.go 38.34% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1b1ca...0805943. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 3, 2017
@silverwind
Copy link
Member

silverwind commented Dec 3, 2017

Did you test if they sort the same like on the main dashboard. I noticed org repos there sort by repo, not org/repo, e.g. org/a sorts before a/b. Thought, I think that sorting by org/repo is probably more intuitive.

@lafriks
Copy link
Member

lafriks commented Dec 3, 2017

I think they should be sorted by name

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Dec 3, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 3, 2017
@ethantkoenig
Copy link
Member Author

@silverwind @lafriks Done

@silverwind
Copy link
Member

Ideally, I think it should first sort the user's own repos and after that the other ones, but that's just nitpicking at this point, any sorting is better than no sorting :)

@lunny
Copy link
Member

lunny commented Dec 4, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 4, 2017
@lafriks
Copy link
Member

lafriks commented Dec 4, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2017
@lunny lunny merged commit c0a7899 into go-gitea:master Dec 4, 2017
@ethantkoenig ethantkoenig deleted the dashboard_repo_order branch December 16, 2017 04:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants