Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix active item in tab menu #30690

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix active item in tab menu #30690

merged 2 commits into from
Apr 25, 2024

Conversation

silverwind
Copy link
Member

Before, item would also resize on hover because of font weight:
Screenshot 2024-04-25 at 01 28 53

After:
Screenshot 2024-04-25 at 01 28 40

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2024
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 25, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 25, 2024
@silverwind silverwind merged commit d0bfc97 into go-gitea:main Apr 25, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 25, 2024
@silverwind silverwind deleted the tabactive branch April 25, 2024 10:53
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 25, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 26, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a31d1b3 
* giteaofficial/main:
  Deduplicate lfs common code (go-gitea#30704)
  Improve job commit description (go-gitea#30579)
  Improve test for TestPullCompare (go-gitea#30699)
  Allow to save empty comment (go-gitea#30706)
  [skip ci] Updated translations via Crowdin
  Refactor imagediff and fix regression bug (go-gitea#30694)
  Improve oauth2 client "preferred username field" logic and the error handling (go-gitea#30622)
  Fix active item in tab menu (go-gitea#30690)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @lunny @techknowlogick @wxiaoguang @GiteaBot