Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misalignment issue in repo header #3062

Merged
merged 2 commits into from
Dec 2, 2017

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 2, 2017

Noticed a issue in the repo header where the commit date was misaligned and there was a visible issue with the bottom-border of the header. Fixed it by removing a seemingly unnecessary vertical-alignment.

Before

screen shot 2017-12-02 at 15 54 27

After

screen shot 2017-12-02 at 15 57 04

Edit: This is on Firefox.

@silverwind
Copy link
Member Author

This was introduced in 86ee41e. cc: @sondr3: what was the purpose of that rule?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 2, 2017
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Dec 2, 2017
@silverwind
Copy link
Member Author

I just tested a expandable commit, looking fine with my change too:

screen shot 2017-12-02 at 16 03 34

screen shot 2017-12-02 at 16 03 25

@lunny
Copy link
Member

lunny commented Dec 2, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2017
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break expandable commits in code file list

@silverwind
Copy link
Member Author

silverwind commented Dec 2, 2017

code file list

Where are those? Got an example?

My test repo is at https://try.gitea.io/silverwind/longlonglonglonglonglong/.

@lafriks
Copy link
Member

lafriks commented Dec 2, 2017

@silverwind
Copy link
Member Author

Ah, I see what I mean. Adjusted the selector to only apply on tbody, which should resolve it.

@lafriks
Copy link
Member

lafriks commented Dec 2, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2017
@silverwind silverwind force-pushed the repo-head-misalignment branch from 791c505 to 256bf69 Compare December 2, 2017 16:09
@silverwind
Copy link
Member Author

Commits squashed.

@codecov-io
Copy link

codecov-io commented Dec 2, 2017

Codecov Report

Merging #3062 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3062      +/-   ##
==========================================
- Coverage   33.46%   33.41%   -0.06%     
==========================================
  Files         270      270              
  Lines       39553    39553              
==========================================
- Hits        13237    13216      -21     
- Misses      24425    24447      +22     
+ Partials     1891     1890       -1
Impacted Files Coverage Δ
models/repo_indexer.go 45.54% <0%> (-7.43%) ⬇️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
modules/indexer/repo.go 60.86% <0%> (-2.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d5ba6...564b9b8. Read the comment docs.

.commit-list {
vertical-align: baseline;
tbody.commit-list {
vertical-align: baseline;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tab back to what is in rest file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, that would contradict .editorconfig. See #3064 for fixing the .less files indendation issues.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the upper half of that file is already intended using spaces, btw :)

@lafriks
Copy link
Member

lafriks commented Dec 2, 2017

Oh well, ok :)

@lafriks lafriks merged commit 8cd616e into go-gitea:master Dec 2, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 2, 2017
@silverwind silverwind deleted the repo-head-misalignment branch December 2, 2017 17:21
@sondr3
Copy link
Contributor

sondr3 commented Dec 3, 2017

I didn’t check in Firefox and it looked fine in Chrome so I didn’t think to check, you can see in my pull request that it aligns properly with my original code. CSS is weird.

@silverwind
Copy link
Member Author

Yes, people often forget to test other browers these day. Generally I'd say "old" methods like tables are weird. Would probably not happened with Flexbox, for example. :)

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants