-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misalignment issue in repo header #3062
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break expandable commits in code file list
Where are those? Got an example? My test repo is at https://try.gitea.io/silverwind/longlonglonglonglonglong/. |
Sorry, I meant commit list - https://try.gitea.io/silverwind/longlonglonglonglonglong/commits/branch/master |
Ah, I see what I mean. Adjusted the selector to only apply on |
LGTM |
791c505
to
256bf69
Compare
Commits squashed. |
Codecov Report
@@ Coverage Diff @@
## master #3062 +/- ##
==========================================
- Coverage 33.46% 33.41% -0.06%
==========================================
Files 270 270
Lines 39553 39553
==========================================
- Hits 13237 13216 -21
- Misses 24425 24447 +22
+ Partials 1891 1890 -1
Continue to review full report at Codecov.
|
.commit-list { | ||
vertical-align: baseline; | ||
tbody.commit-list { | ||
vertical-align: baseline; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix tab back to what is in rest file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, that would contradict .editorconfig
. See #3064 for fixing the .less
files indendation issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the upper half of that file is already intended using spaces, btw :)
Oh well, ok :) |
I didn’t check in Firefox and it looked fine in Chrome so I didn’t think to check, you can see in my pull request that it aligns properly with my original code. CSS is weird. |
Yes, people often forget to test other browers these day. Generally I'd say "old" methods like tables are weird. Would probably not happened with Flexbox, for example. :) |
Noticed a issue in the repo header where the commit date was misaligned and there was a visible issue with the bottom-border of the header. Fixed it by removing a seemingly unnecessary
vertical-alignment
.Before
After
Edit: This is on Firefox.