Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use action user as the trigger user of schedules (#30581) #30610

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

GiteaBot
Copy link
Collaborator

Backport #30581 by @yp05327

Follow #30357

When user push to default branch, the schedule trigger user will be the user.
When disable then enable action units in settings, the schedule trigger user will be action user.
When repo is a mirror, the schedule trigger user will be action user. ( before it will return error, fixed by #30357)

As scheduled job is a cron, the trigger user should be action user from Gitea, not a real user.

Follow go-gitea#30357

When user push to default branch, the schedule trigger user will be the
user.
When disable then enable action units in settings, the schedule trigger
user will be action user.
When repo is a mirror, the schedule trigger user will be action user. (
before it will return error, fixed by go-gitea#30357)

As scheduled job is a cron, the trigger user should be action user from
Gitea, not a real user.

---------

Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot added the modifies/go Pull requests that update Go code label Apr 20, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 20, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 20, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2024
@GiteaBot GiteaBot requested review from lunny and wolfogre April 20, 2024 00:35
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 20, 2024
@lunny lunny merged commit 60f0493 into go-gitea:release/v1.22 Apr 20, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 20, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants