Avoid running action when action unit is disabled after workflows detected (#30331) #30338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected (go-gitea#30331) Fix go-gitea#30243 We only checking unit disabled when detecting workflows, but not in runner `FetchTask`. So if a workflow was detected when action unit is enabled, but disabled later, `FetchTask` will still return these detected actions. Global setting: repo.ENABLED and repository.`DISABLED_REPO_UNITS` will not effect this.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
lunny
approved these changes
Apr 8, 2024
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Apr 8, 2024
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #30331 by @yp05327
Fix #30243
We only checking unit disabled when detecting workflows, but not in runner
FetchTask.So if a workflow was detected when action unit is enabled, but disabled later,
FetchTaskwill still return these detected actions.Global setting: repo.ENABLED and repository.
DISABLED_REPO_UNITSwill not effect this.