Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate "Max Diff Lines" from config view #2987

Merged
merged 3 commits into from
Nov 27, 2017
Merged

Remove duplicate "Max Diff Lines" from config view #2987

merged 3 commits into from
Nov 27, 2017

Conversation

mrexodia
Copy link
Contributor

@lafriks
Copy link
Member

lafriks commented Nov 27, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 27, 2017
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Nov 27, 2017
@lafriks lafriks added this to the 1.4.0 milestone Nov 27, 2017
@codecov-io
Copy link

codecov-io commented Nov 27, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@0e76f38). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2987   +/-   ##
=========================================
  Coverage          ?   32.49%           
=========================================
  Files             ?      267           
  Lines             ?    39270           
  Branches          ?        0           
=========================================
  Hits              ?    12760           
  Misses            ?    24718           
  Partials          ?     1792

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e76f38...1fb45fb. Read the comment docs.

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 27, 2017
@lafriks lafriks merged commit 8ee08fe into go-gitea:master Nov 27, 2017
@lunny
Copy link
Member

lunny commented Nov 27, 2017

Is this still on v1.3?

@lafriks
Copy link
Member

lafriks commented Nov 27, 2017

I think yes

@lunny
Copy link
Member

lunny commented Nov 27, 2017

So please send a back port

@lafriks
Copy link
Member

lafriks commented Nov 27, 2017

@mrexodia can you backport this to release/v1.3 branch?

@mrexodia
Copy link
Contributor Author

Should I do something for this?

@lafriks
Copy link
Member

lafriks commented Nov 27, 2017

Create new PR targeting v1.3 branch with cherry-pick'ed merge commit of this PR

@mrexodia mrexodia mentioned this pull request Nov 27, 2017
Merged
@mrexodia mrexodia deleted the remove-duplicate-config branch November 27, 2017 13:13
@lunny lunny added the backport/done All backports for this PR have been created label Nov 27, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mrexodia @lafriks @codecov-io @ethantkoenig @lunny @tboerger