Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App restarts to quickly if it fails to start. #2945

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

wmantly
Copy link
Contributor

@wmantly wmantly commented Nov 20, 2017

Systemd has a default restart time of 100ms. This does not allow enough time if the app fails to start.

@codecov-io
Copy link

Codecov Report

Merging #2945 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2945   +/-   ##
=======================================
  Coverage   27.24%   27.24%           
=======================================
  Files          89       89           
  Lines       17640    17640           
=======================================
  Hits         4806     4806           
  Misses      12146    12146           
  Partials      688      688

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6c198...f10ac95. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 20, 2017
@lafriks
Copy link
Member

lafriks commented Nov 20, 2017

LGTM

@lafriks lafriks added this to the 1.4.0 milestone Nov 20, 2017
@cez81
Copy link
Contributor

cez81 commented Nov 20, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 20, 2017
@lafriks lafriks merged commit e4f96c6 into go-gitea:master Nov 20, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants