-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust changelog for v1.21.6 to move prs to correct labels #29339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/docs
This PR mainly updates/creates documentation
frontport/main
This PR is not targeting the main branch. Still, its changes should also be added there
labels
Feb 23, 2024
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Feb 23, 2024
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Feb 23, 2024
wolfogre
approved these changes
Feb 23, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Feb 23, 2024
6543
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well for v1.21.6 i had not much time ... anywa fixing it now is better than nothing :)
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 23, 2024
wxiaoguang
reviewed
Feb 23, 2024
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Feb 23, 2024
…29339) When releasing, the releaser should read all the pull requests carefully and do some adjustments because some of pull requests' labels are not right when it's merged. And the changelog tool needs to be adjusted. If one pull request has both `bug` and `API`, it should mark it as `bug` but not `API`.
6543
pushed a commit
that referenced
this pull request
Feb 23, 2024
…29343) When releasing, the releaser should read all the pull requests carefully and do some adjustments because some of pull requests' labels are not right when it's merged. And the changelog tool needs to be adjusted. If one pull request has both `bug` and `API`, it should mark it as `bug` but not `API`. Backport #29339
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 23, 2024
* giteaofficial/main: Adjust changelog for v1.21.6 to move prs to correct labels (go-gitea#29339) (go-gitea#29343) Allow options to disable user deletion from the interface on app.ini (go-gitea#29275)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
frontport/main
This PR is not targeting the main branch. Still, its changes should also be added there
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/docs
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
type/docs
This PR mainly updates/creates documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When releasing, the releaser should read all the pull requests carefully and do some adjustments because some of pull requests' labels are not right when it's merged.
And the changelog tool needs to be adjusted. If one pull request has both
bug
andAPI
, it should mark it asbug
but notAPI
.