Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix organization field being null in POST /orgs/{orgid}/teams (#27150) #27163

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

GiteaBot
Copy link
Collaborator

Backport #27150 by @memphis88

Similarly to the fix in #24694, this addresses the team creation not returning the organization information in the response.

This fix is connected to the issue discovered in the terraform provider.
Moreover, the documentation suggests that the response body should include the organization field (currently being null).

…ea#27150)

Similarly to the fix in go-gitea#24694,
this addresses the team creation not returning the organization
information in the response.

This fix is connected to the
[issue](https://gitea.com/gitea/terraform-provider-gitea/issues/27)
discovered in the terraform provider.
Moreover, the
[documentation](https://docs.gitea.com/api/1.20/#tag/organization/operation/orgCreateTeam)
suggests that the response body should include the `organization` field
(currently being `null`).
@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them type/bug lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 21, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Sep 21, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 21, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 21, 2023
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 21, 2023
@silverwind silverwind merged commit 0ca2332 into go-gitea:release/v1.21 Sep 21, 2023
@GiteaBot
Copy link
Collaborator Author

@GiteaBot please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 21, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants