Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing deps to files-changed, downgrade markdownlint-cli #27100

Merged
merged 4 commits into from
Sep 16, 2023
Merged

Add missing deps to files-changed, downgrade markdownlint-cli #27100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e729076
Add missing deps to files-changed
silverwind Sep 16, 2023
1ee22ed
add Makefile to actions for actionslint
silverwind Sep 16, 2023
ff477de
downgrade markdownlint-cli
silverwind Sep 16, 2023
fda7060
Merge branch 'main' into deps-deps
GiteaBot Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/files-changed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,12 @@ jobs:
- "**/*.md"
- "docs/**"
- ".markdownlint.yaml"
- "package.json"
- "package-lock.json"
Comment on lines +67 to +68
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those two are a bit weird for the docs category.
If I see that correctly, it'll mean that any JS dependency update or new JS feature will be marked as kind/docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add or remove the kind/docs

Copy link
Member Author

@silverwind silverwind Sep 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the labels config, this is the actions config. mardownlint-cli version is defined in these files, if those change we need to run the docs workflow to confirm the lnting still works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it.


actions:
- ".github/workflows/*"
- "Makefile"

templates:
- "templates/**/*.tmpl"
Expand All @@ -90,3 +93,5 @@ jobs:
- "**/*.yml"
- "**/*.yaml"
- ".yamllint.yaml"
- "pyproject.toml"
- "poetry.lock"
62 changes: 31 additions & 31 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"eslint-plugin-vue-scoped-css": "2.5.0",
"eslint-plugin-wc": "1.5.0",
"jsdom": "22.1.0",
"markdownlint-cli": "0.36.0",
"markdownlint-cli": "0.35.0",
"postcss-html": "1.5.0",
"stylelint": "15.10.3",
"stylelint-declaration-block-no-ignored-properties": "2.7.0",
Expand Down