Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support displaying diff stats in PR tab bar #25387

Merged
merged 20 commits into from
Jul 3, 2023
Merged

Support displaying diff stats in PR tab bar #25387

merged 20 commits into from
Jul 3, 2023

Conversation

hiifong
Copy link
Member

@hiifong hiifong commented Jun 20, 2023 •
edited
Loading

Fix #25326

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 20, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 20, 2023
@hiifong hiifong marked this pull request as draft June 20, 2023 07:13
@silverwind
Copy link
Member

Align it to far-right? I assume a margin-left: auto shall do.

@hiifong
Copy link
Member Author

hiifong commented Jun 20, 2023

Align it to far-right? I assume a margin-left: auto shall do.

I don't know how to adjust the css style, can you help me?

@silverwind
Copy link
Member

Yeah I can try to adjust it later.

@silverwind
Copy link
Member

silverwind commented Jun 20, 2023 •
edited
Loading

Styling enhancement done in afb787d:

image

@silverwind silverwind added the type/enhancement An improvement of existing functionality label Jun 20, 2023
@hiifong hiifong marked this pull request as ready for review June 20, 2023 19:08
@hiifong hiifong changed the title [WIP] Diff stats in PR tab bar Diff stats in PR tab bar Jun 20, 2023
@hiifong hiifong marked this pull request as draft June 21, 2023 06:20
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2023
@hiifong hiifong requested a review from silverwind June 21, 2023 10:39
lunny
lunny reviewed Jun 21, 2023
View reviewed changes
routers/web/repo/pull.go Outdated Show resolved Hide resolved
@hiifong hiifong changed the title Diff stats in PR tab bar Support displaying diff stats in PR tab bar Jun 22, 2023
hiifong
hiifong commented Jun 22, 2023
View reviewed changes
routers/web/repo/pull.go Outdated

var prInfo *git.CompareInfo

if pull.HasMerged {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need it?

@hiifong hiifong marked this pull request as ready for review June 22, 2023 03:49
lunny
lunny reviewed Jun 28, 2023
View reviewed changes
routers/web/repo/pull.go Outdated Show resolved Hide resolved
lunny
lunny reviewed Jun 28, 2023
View reviewed changes
routers/web/repo/pull.go Outdated Show resolved Hide resolved
lunny
lunny reviewed Jun 28, 2023
View reviewed changes
routers/web/repo/pull.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2023
@hiifong hiifong requested a review from lunny June 28, 2023 10:48
@silverwind
Copy link
Member

silverwind commented Jun 28, 2023 •
edited
Loading

Make sure to resolve and ideally also comment on all review threads, so that we can track which/why changes are done.

@hiifong
Copy link
Member Author

hiifong commented Jun 30, 2023

#25387 (review) is not sure

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 30, 2023
@denyskon denyskon mentioned this pull request Jul 1, 2023
Closed
@denyskon denyskon added this to the 1.21.0 milestone Jul 2, 2023
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 2, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) July 3, 2023 00:54
@techknowlogick techknowlogick merged commit 36f1fa7 into go-gitea:main Jul 3, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 3, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 3, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
663fc74 
* giteaofficial/main:
  use css on labels (go-gitea#25626)
  Get latest commit statuses from database instead of git data on dashboard for repositories (go-gitea#25605)
  Add log line anchor for action logs (go-gitea#25532)
  Support displaying diff stats in PR tab bar (go-gitea#25387)
  [skip ci] Updated licenses and gitignores
@hiifong hiifong deleted the add_diff_stats_into_pr_tab_bar branch July 9, 2023 09:18
@wxiaoguang wxiaoguang mentioned this pull request Aug 5, 2023
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Diff stats in PR tab bar
7 participants
@hiifong @silverwind @lunny @wxiaoguang @techknowlogick @GiteaBot @denyskon