-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make confusable character warning less jarring #25069
Conversation
This commit assumes that the warning can be made more discreet so as to make it less annoying for the people that do not actually need the warning, without necessarily increasing the risk for those that do need it. This doesn't fix the underlying problem of the warning being shown in certain cases that, say, a certain kind of whitespace character like 0x1E could be absolutely justifiable from a technical perspective.
No I considered two cases:
|
Any screenshot? |
Sure, give me a second. |
Full disclosure that I should've mentioned earlier: Considering that the change is minor and does not contain any logic changes or anything that could otherwise prevent the site from rendering correctly, I recreated the change again using "Inspect Element" (removed the tag, changed the text content) on Codeberg to save time. I didn't see a reason to do so, but I can test this thoroughly if necessary. |
Co-authored-by: delvh <[email protected]>
Co-authored-by: delvh <[email protected]>
Thanks for this PR. I'm hesitant to approve with the warning removed, as this is in place to remedy a security concern and otherwise the security reporters had wanted to request a CVE without the warning. |
Maybe we could use Feel free to close this if you believe that this isn't the right way to do this. |
I think using warning in both cases would be the best compromise. |
I addressed this. |
@techknowlogick Do you want to block or is this compromise acceptable for you? |
* upstream/main: Make confusable character warning less jarring (go-gitea#25069) Update Gmail example (go-gitea#26302) Fix the topic validation rule and suport dots (go-gitea#26286) Upgrade x/net to 0.13.0 (go-gitea#26297) add unit test for user renaming (go-gitea#26261) add some Wiki unit tests (go-gitea#26260)
This commit assumes that the warning can be made more discreet
so as to make it less annoying for the people that do not actually
need the warning, without necessarily increasing the risk for those
that do need it.
This doesn't fix the underlying problem of the warning being shown
in certain cases that, say, a certain kind of whitespace character
like 0x1E could be absolutely justifiable from a technical
perspective.