-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add enhancements of profile readmes #24753
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follow go-gitea#23260, do some enhancement to make it better. - reuse readme file finding and render logic in repo file render function, then all features in repo's readme file like locolize file name, file reference and issue/pull reference will be usefull alse. that's same with github. - make profile repo name configable for all user (TIP: you can disable it by entry a not exist repository name :) ) - less `serverError` in profile readme render logic Signed-off-by: a1012112796 <[email protected]>
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 16, 2023
pull-request-size
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also not show private repos but that can be another PR
Co-authored-by: Yarden Shoham <[email protected]>
lunny
reviewed
May 17, 2023
silverwind
pushed a commit
that referenced
this pull request
Aug 4, 2023
As mentioned in the original thread (#23260) and in the enhancements PR #24753, this PR ensures the .profile repository is public before the README file is shown. Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: Giteabot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow #23260, do some enhancement to make it better.
reuse readme file finding and render logic in repo file render function, then all features in repo's readme file like locolize file name, file reference (like using figure in profile repo) and issue/pull reference will be usefull alse. that's same with github.
example:
make profile repo name configable for all user (TIP: you can disable it by entry a not exist repository name :) )
less
serverError
in profile readme render logic