Improve decryption failure message #24573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
added
the
outdated/backport/v1.19
wxiaoguang
force-pushed
the
improve-secret-err
branch
from
d540aa6 to
cb29e30
Compare
delvh
reviewed
May 7, 2023
Co-authored-by: delvh <[email protected]>
wxiaoguang
force-pushed
the
improve-secret-err
branch
from
bd87789 to
dc96bec
Compare
delvh
approved these changes
May 7, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 7, 2023
GiteaBot
added
lgtm/done
|
I was unable to create a backport for 1.19. @wxiaoguang, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
May 7, 2023
lunny
pushed a commit
that referenced
this pull request
May 7, 2023
Backport #24573 Help some users like #16832 #1851 There are many users reporting similar problem: if the SECRET_KEY mismatches, some operations (like 2FA login) only reports unclear 500 error and unclear "base64 decode error" log （some maintainers ever spent a lot of time on debugging such problem) The SECRET_KEY was not well-designed and it is also a kind of technical debt. Since it couldn't be fixed easily, it's good to add clearer error messages, then at least users could know what the real problem is.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 8, 2023
* upstream/main: Fix broken link in tests/e2e/README (go-gitea#24576) [skip ci] Updated licenses and gitignores Add goto issue id function (go-gitea#24479) Improve decryption failure message (go-gitea#24573) Simplify template helper functions (go-gitea#24570) Makefile: Use portable !, not GNUish -not, with find(1). (go-gitea#24565) Add org visibility label to non-organization's dashboard (go-gitea#24558) Sort users and orgs on explore by recency by default (go-gitea#24279) Change `add_on` translation to `added_on` and include placeholder for the date (go-gitea#24562) Change `valid_until` translation to `valid_until_date` and include placeholder for the date (go-gitea#24563) Fix docs failing the build on `main` (go-gitea#24561) Improve wiki user title test (go-gitea#24559) Fix incorrect user visibility (go-gitea#24557) Change `join_on` translation to `joined_on` and include placeholder for the date (go-gitea#24550) Require at least one unit to be enabled (go-gitea#24189) Fix broken `README` link (go-gitea#24546) Check latest version on CI (go-gitea#24556)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help some users like #16832 #1851
There are many users reporting similar problem: if the SECRET_KEY mismatches, some operations (like 2FA login) only reports unclear 500 error and unclear "base64 decode error" log （some maintainers ever spent a lot of time on debugging such problem)
The SECRET_KEY was not well-designed and it is also a kind of technical debt. Since it couldn't be fixed easily, it's good to add clearer error messages, then at least users could know what the real problem is.