Fix footer display #24251
Merged
Fix footer display #24251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
Closed
lunny
added
type/bug
outdated/backport/v1.19
pull-request-size
bot
added
size/L
|
Regression from #24184? |
GiteaBot
added
the
lgtm/need 2
|
Yup, and this PR fixes more (eg: the language menu for short language names) and simplifies the code. |
|
Ok than backport is needed. Strange that I did not see it in my testing. |
silverwind
reviewed
Apr 21, 2023
silverwind
approved these changes
Apr 21, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 22, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
I was unable to create a backport for 1.19. @wxiaoguang, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Apr 22, 2023
Fix go-gitea#24249 Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/24251/files?diff=split&w=1 Screenshots: <details> <img width="1440" alt="image" src="https://user-images.githubusercontent.com/2114189/233592840-d9ef7296-64eb-4e48-a598-300807a7c2f9.png"> <img width="923" alt="image" src="https://user-images.githubusercontent.com/2114189/233593015-16edc531-43c2-4ff0-b27e-ca75dbadce0c.png"> </details> --------- Co-authored-by: silverwind <[email protected]> Co-authored-by: Giteabot <[email protected]>
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Apr 22, 2023
silverwind
pushed a commit
that referenced
this pull request
Apr 22, 2023
Backport #24251 Fix #24249 Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/24269/files?diff=split&w=1 Manually tested  Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24249
Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/24251/files?diff=split&w=1
Screenshots: