Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stars in dashboard repo list #23530

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Remove stars in dashboard repo list #23530

merged 3 commits into from
Mar 17, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Mar 17, 2023

Discussion is here: #22816

@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Mar 17, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Mar 17, 2023
@silverwind
Copy link
Member

It may be possible that there is some CSS to remove as well, should double-check.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 17, 2023
@silverwind
Copy link
Member

Don't see any CSS, so we should be good on that front.

Please remove gt-mr-2 on line 75, it's no longer necessary.

@yp05327
Copy link
Contributor Author

yp05327 commented Mar 17, 2023

Please remove gt-mr-2 on line 75, it's no longer necessary.

Done.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 17, 2023
@wxiaoguang
Copy link
Contributor

Please remove gt-mr-2 on line 75, it's no longer necessary.

I guess most styles are unnecessary now, because there is only one element for the link now. (just curious, not a must 😁 )

@silverwind
Copy link
Member

I guess most styles are unnecessary now, because there is only one element for the link now. (just curious, not a must 😁 )

Those flex-related styles are good to keep I think, especially the f1.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) March 17, 2023 03:55
@techknowlogick
Copy link
Member

ping lg-tm

@techknowlogick techknowlogick merged commit 06c067b into go-gitea:main Mar 17, 2023
@techknowlogick techknowlogick removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
6 participants
@yp05327 @silverwind @wxiaoguang @techknowlogick @lunny @GiteaBot