Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change button text for commenting and closing an issue at the same time (#23135) #23181

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Change button text for commenting and closing an issue at the same time (#23135) #23181

merged 2 commits into from
Feb 28, 2023

Conversation

yardenshoham
Copy link
Member

Backport #23135

Close #10468

Without SimpleMDE/EasyMDE, using Simple Textarea, the button text could be changed when content changes.

After introducing SimpleMDE/EasyMDE, there is no code for updating the button text.

image

@wxiaoguang @yardenshoham
Change button text for commenting and closing an issue at the same ti…
b99bef0 
…me (go-gitea#23135)

Close  go-gitea#10468

Without SimpleMDE/EasyMDE, using Simple Textarea, the button text could
be changed when content changes.

After introducing SimpleMDE/EasyMDE, there is no code for updating the
button text.
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 28, 2023 •
edited
Loading

Please wait for #23168 together, it fixes a regression bug of undefined-checking.🙏

The correct fix would be like below.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2023
@yardenshoham yardenshoham added this to the 1.18.6 milestone Feb 28, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2023
@techknowlogick techknowlogick merged commit ceedb49 into go-gitea:release/v1.18 Feb 28, 2023
@yardenshoham yardenshoham deleted the backport-23135-v1.18 branch March 1, 2023 06:07
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.18.6
Development

Successfully merging this pull request may close these issues.
5 participants
@yardenshoham @wxiaoguang @lunny @techknowlogick @GiteaBot