Fix UI language switching bug

docs/content/doc/installation/with-docker.en-us.md

@@ -98,6 +98,13 @@ services:
 
 ## Databases
 
+### SQLite3 database
+
+Use the above "basic" docker-compose config, set "Database Type" to SQLite3 on the installation page.
+
+SQLite3 is only suitable for small instance and for only a few users.
+It's recommended to use other database servers for production instances.
+
 ### MySQL database
 
 To start Gitea in combination with a MySQL database, apply these changes to the

modules/web/middleware/locale.go

@@ -19,6 +19,7 @@ func Locale(resp http.ResponseWriter, req *http.Request) translation.Locale {
 	// 1. Check URL arguments.
 	lang := req.URL.Query().Get("lang")
 	changeLang := lang != ""
+	skipHandler := req.URL.Query().Get("lang_skip_handler") != ""
 
 	// 2. Get language information from cookies.
 	if len(lang) == 0 {
@@ -46,7 +47,15 @@ func Locale(resp http.ResponseWriter, req *http.Request) translation.Locale {
 		SetLocaleCookie(resp, lang, 1<<31-1)
 	}
 
-	return translation.NewLocale(lang)
+	err := translation.NewLocale(lang)
+	if err != nil {
+		return err
+	}
+
+	if skipHandler {
+		resp.WriteHeader(http.StatusNoContent)
+	}
+	return nil
 }
 
 // SetLocaleCookie convenience function to set the locale cookie consistently

routers/install/install.go

@@ -113,7 +113,7 @@ func Install(ctx *context.Context) {
 		}
 	}
 	if !isCurDBTypeSupported {
-		curDBType = "mysql"
+		curDBType = setting.SupportedDatabaseTypes[0]
 	}
 	ctx.Data["CurDbType"] = curDBType
 

web_src/js/features/common-global.js

@@ -36,8 +36,11 @@ export function initHeadNavbarContentToggle() {
 
 export function initFootLanguageMenu() {
   function linkLanguageAction() {
-    const $this = $(this);
-    $.post($this.data('url')).always(() => {
+    let changeLangUrl = $(this).attr('data-url');
+    changeLangUrl += changeLangUrl.includes('?') ? '&' : '?';
+    // Only use "lang_skip_handler" for ajax. Page links should not have this parameter because crawlers need to get the full page
+    changeLangUrl += 'lang_skip_handler=1';
+    $.get(changeLangUrl).always(() => {
       window.location.reload();
     });
   }