Implement Issue Config #20956

JakobDev · 2022-08-25T13:00:19Z

Closes #20955

This PR adds the possibility to disable blank Issues, when the Repo has templates. This can be done by creating the file .gitea/issue_config.yaml with the content blank_issues_enabled in the Repo.

I have no experience in Go, so this code might not be perfect, but it is working. If anybody knows how to do that better, just say it. It is also missing documentation at the moment.

lunny · 2022-08-29T07:05:51Z

should the path be .gitea/issue_template/config.yaml and to keep compatible with Github to support .github/issue_template/config.yaml

JakobDev · 2022-08-29T09:31:20Z

@lunny I have now changed the paths

modules/context/repo.go

JakobDev · 2022-12-13T08:37:31Z

@lunny Any more suggestions or should I add documentation, so this can be merged?

lunny · 2022-12-13T11:37:55Z

Hi, sorry to be late to reply. Maybe you could add some documentation and tests? And maybe @wolfogre could also have a review because he contributed some related PRs.

JakobDev · 2022-12-13T12:03:06Z

The documentation has now been added, but i don't know, how to write tests for this.

modules/context/repo.go

routers/web/repo/issue.go

docs/content/doc/usage/issue-pull-request-templates.en-us.md

delvh · 2022-12-13T16:27:05Z

docs/content/doc/usage/issue-pull-request-templates.en-us.md

+
+### Possible Options
+
+| Key                | Description                                                                                           | Type    |


I think Default is also a good idea for this table.

templates/repo/issue/choose.tmpl

modules/context/repo.go

docs/content/doc/usage/issue-pull-request-templates.en-us.md

JakobDev · 2022-12-20T14:10:13Z

I had now done a bit of code refactoring:

I now use yaml.v3
The list with the filenames is shorten
If a Issue config contains a error, it is now shown while viewing the file

ctx.Flash.Error() requires loading the config every time you visit the main page of the repo (which is a waste of resources), or else it will just be shown after visiting, the Issue template list, which is confusing, so I decided to stick with the current solution.

routers/web/repo/issue.go

templates/repo/issue/choose.tmpl

docs/content/doc/usage/issue-pull-request-templates.en-us.md

modules/context/repo.go

lunny · 2023-02-16T10:06:51Z

Need @delvh approval.

JakobDev · 2023-03-03T10:38:37Z

Ping @delvh

wxiaoguang · 2023-03-15T06:12:38Z

Happened to see this PR ..... maybe the maintainer team need some mechanisms to handle the "pending reviews"?

Should I help to call the TOC (again)?

lunny · 2023-03-15T06:18:29Z

Need @delvh 's review.

delvh

Yep, sorry for the late reply, my TODO list is way too long already.
Furthermore, I'm still not quite a fan of using a boolean where I think a string is more fitting.
However, I can at least accept this PR assuming everyone knows that this is probably not the best option for a long-term solution.

modules/context/repo.go

modules/structs/issue.go

delvh

I've now tested the functionality.
A few closing remarks:

I think the API route can be either under repo or under issue. I can certainly see why it's currently under repo. GitHub doesn't offer this API at the moment, so I'm fine with both
I am not a fan of having _ in URLs but seeing that other URLs also have the _ already, I'll allow it
There should be a divider between the issue templates and the contact links, however, this can be postponed for a later PR:

I'm still not a fan of using a boolean for that struct, but other than that I don't see anything holding this PR back.

JakobDev · 2023-03-28T06:30:38Z

There should be a divider between the issue templates and the contact links, however, this can be postponed for a later PR:

I personally prefer it when it has no divider and everything looks the same (except for the buttons) in the box.

I'm still not a fan of using a boolean for that struct, but other than that I don't see anything holding this PR back.

I still think, it's better to add a extra setting. A string that is a boolean is confusing and can cause problems with the API.

jolheiser · 2023-03-28T17:57:15Z

🎺 🤖

* upstream/main: Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (go-gitea#23687) Add CSS rules for basic colored labels (go-gitea#23774) Add meilisearch support (go-gitea#23136) Add missing translation for `actions.runners.reset_registration_token_success` (go-gitea#23732) [skip ci] Updated translations via Crowdin Implement Issue Config (go-gitea#20956) Set repository link based on the url in package.json for npm packages (go-gitea#20379) Add API to manage issue dependencies (go-gitea#17935) Add creation time in tag list page (go-gitea#23693) Make minio package support legacy MD5 checksum (go-gitea#23768) Yarden Shoham has a new email address (go-gitea#23767) fix br display for packages curls (go-gitea#23737)

Allow disabling blank Issues

fac2cb6

JakobDev mentioned this pull request Aug 29, 2022

Support Issue forms and PR forms #20987

Merged

8 tasks

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 29, 2022

Change supported paths

adb916e

JakobDev added 3 commits August 29, 2022 16:53

Change config paths

c7a8ee4

Merge branch 'main' into noblankissues

4d008fc

Fix bugs

ecbbbe9

lunny reviewed Sep 2, 2022

View reviewed changes

modules/context/repo.go Show resolved Hide resolved

Return error when getting default branch fails

7b4415b

jolheiser mentioned this pull request Nov 23, 2022

Ability to disable default issue template #21914

Closed

lunny added the type/enhancement An improvement of existing functionality label Nov 23, 2022

JakobDev mentioned this pull request Dec 1, 2022

Plans for Gitea 1.19 #21598

Closed

Merge branch 'main' into noblankissues

bdd3c2a

Add documentation

146bd6b

delvh reviewed Dec 13, 2022

View reviewed changes

wolfogre reviewed Dec 14, 2022

View reviewed changes

Refactor code

bb72aea

JakobDev requested review from lunny, wolfogre and delvh and removed request for lunny and wolfogre December 20, 2022 14:10

delvh reviewed Dec 20, 2022

View reviewed changes

karolyi mentioned this pull request Dec 23, 2022

[Docs] Document how to modify the default issue template #14383

Open

GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Feb 16, 2023

JakobDev mentioned this pull request Mar 3, 2023

Plans for Gitea 1.20 #23072

Closed

lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 15, 2023

lunny added this to the 1.20.0 milestone Mar 15, 2023

delvh reviewed Mar 15, 2023

View reviewed changes

modules/context/repo.go Show resolved Hide resolved

modules/structs/issue.go Outdated Show resolved Hide resolved

modules/structs/issue.go Show resolved Hide resolved

lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 15, 2023

delvh self-requested a review March 15, 2023 20:41

Merge branch 'main' into noblankissues

7a4c6f8

This comment was marked as off-topic.

Sign in to view

JakobDev added 3 commits March 27, 2023 10:34

Rename IssueConfigValidate to IssueConfigValidation

159c0f7

Missed test

68f508b

Typo

609840c

delvh approved these changes Mar 27, 2023

View reviewed changes

Merge branch 'main' into noblankissues

31d1353

delvh added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/enhancement An improvement of existing functionality labels Mar 28, 2023

Merge branch 'main' into noblankissues

d4a69d5

jolheiser enabled auto-merge (squash) March 28, 2023 17:57

jolheiser merged commit f384b13 into go-gitea:main Mar 28, 2023

jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 28, 2023

JakobDev deleted the noblankissues branch March 28, 2023 18:24

go-gitea locked and limited conversation to collaborators May 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Issue Config #20956

Implement Issue Config #20956

JakobDev commented Aug 25, 2022

lunny commented Aug 29, 2022

JakobDev commented Aug 29, 2022

JakobDev commented Dec 13, 2022

lunny commented Dec 13, 2022

JakobDev commented Dec 13, 2022

delvh Dec 13, 2022 •

edited

Loading

JakobDev commented Dec 20, 2022

lunny commented Feb 16, 2023

JakobDev commented Mar 3, 2023

wxiaoguang commented Mar 15, 2023

lunny commented Mar 15, 2023

delvh left a comment

This comment was marked as off-topic.

delvh left a comment

JakobDev commented Mar 28, 2023

jolheiser commented Mar 28, 2023

Implement Issue Config #20956

Implement Issue Config #20956

Conversation

JakobDev commented Aug 25, 2022

lunny commented Aug 29, 2022

JakobDev commented Aug 29, 2022

JakobDev commented Dec 13, 2022

lunny commented Dec 13, 2022

JakobDev commented Dec 13, 2022

delvh Dec 13, 2022 • edited Loading

Choose a reason for hiding this comment

JakobDev commented Dec 20, 2022

lunny commented Feb 16, 2023

JakobDev commented Mar 3, 2023

wxiaoguang commented Mar 15, 2023

lunny commented Mar 15, 2023

delvh left a comment

Choose a reason for hiding this comment

This comment was marked as off-topic.

delvh left a comment

Choose a reason for hiding this comment

JakobDev commented Mar 28, 2023

jolheiser commented Mar 28, 2023

delvh Dec 13, 2022 •

edited

Loading