Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uppercase first languages letters #19965

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Uppercase first languages letters #19965

merged 2 commits into from
Jun 15, 2022

Conversation

AHOHNMYC
Copy link
Contributor

Because some languages started from uppercase and others from lower case.

wxiaoguang
wxiaoguang approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's also a longstanding question in my mind why some of the first letters are lower-cased. 😊

I think it's correct to make them upper-cased.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 14, 2022
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Jun 14, 2022
@delvh
Copy link
Member

delvh commented Jun 14, 2022

I asked the same question once in #18211:

Now, it is also visible that for some reason many locales have lowercase names while others have uppercase names.
Should we unify them to all be uppercased or lowercased (where possible)?

With the corresponding answer from @zeripath:

The problem is that in most romance languages the language does not have an upper case letter.
However, I think it's valid in almost all languages that the first letter of a list should be capitalized if any of the others are capitalized so I think we can validly force ToTitle when rendering the languages as a list like this.

I'm not entirely sure if that's now a "yes please" or a "please no"...

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 14, 2022 •
edited
Loading

I did a quick google search (and wikipedia search), most language names can have the first letter upper-cased.

The only exceptions seem to be Српски and Ελληνικά (if I understand correctly ...) update: there seems no exception. see comment below.

@AHOHNMYC
Copy link
Contributor Author

@wxiaoguang yess! Absolutely in every first project French and Russian languages starts from lower case. This is the greatest mystery in FOSS world :)

@lunny
Copy link
Member

lunny commented Jun 14, 2022

I did a quick google search (and wikipedia search), most language names can have the first letter upper-cased.

The only exceptions seem to be Српски and Ελληνικά (if I understand correctly ...)

But then they are not native. Just like you want an Uppercase of Chinese.

@wxiaoguang
Copy link
Contributor

I would choose to believe native speakers and wikipedia. If no native speakers, then there is wikipedia (in most cases it should be correct)

About Just like you want an Uppercase of Chinese. but there is no way to get the uppercase letters in Chinese because there is no uppercase. They are different from the languages which have uppercase letters.

delvh
delvh approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, if no one has any objections about the upper case names of the languages.
Do we know by now how to display српски and ελληνικά?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2022
wxiaoguang
wxiaoguang reviewed Jun 15, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to revert to српски and ελληνικά.

Let's keep this PR open for a few days before merge.

Update: it seems that no problem for these two, I search again, the result is as below.

So, let's trust Google and Wikipedia and keep them.

image

image

@6543 6543 merged commit 97548d2 into go-gitea:main Jun 15, 2022
@AHOHNMYC AHOHNMYC deleted the uppercase-locales branch June 15, 2022 16:40
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 16, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bec4d38 
* giteaofficial/main:
  Allow render HTML with css/js external links (go-gitea#19017)
  Use correct count for `NumOpenIssues` (go-gitea#19980)
  In code search, get code unit accessible repos in one (main) query (go-gitea#19764)
  [skip ci] Updated translations via Crowdin
  Always try to fetch repo for mirrors (go-gitea#19975)
  Remove tab/TabName usage where it's not needed (go-gitea#19973)
  Fix cli command restore-repo: "units" should be parsed as StringSlice (go-gitea#19953)
  Uppercase first languages letters (go-gitea#19965)
  Move tests as seperate sub packages to reduce duplicated file names (go-gitea#19951)
  Replace unstyled meter with progress (go-gitea#19968)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Remove singuliere from MAINTAINERS (go-gitea#19883)
  Fix aria for logo (go-gitea#19955)
  Fix mirror template bug (go-gitea#19959)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@AHOHNMYC
Uppercase first languages letters (go-gitea#19965)
f38e340
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@AHOHNMYC @AbdulrhmnGhanem
Uppercase first languages letters (go-gitea#19965)
5059c27
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@AHOHNMYC @delvh @wxiaoguang @lunny @6543 @GiteaBot