Support hostname:port to pass host matcher's check (#19543)
#19544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
changed the title
hostname:port to pass host matcher's check #19543
jolheiser
approved these changes
Apr 28, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
changed the title
hostname:port to pass host matcher's check #19543 hostname:port to pass host matcher's check (#19543)
lunny
approved these changes
Apr 28, 2022
GiteaBot
added
lgtm/done
Codeberg-org
pushed a commit
to Codeberg-org/gitea
that referenced
this pull request
Apr 28, 2022
…go-gitea#19544) Backport go-gitea#19543 hostmatcher: split the hostname from the hostname:port string, use the correct hostname to do the match.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #19543
Before: ip:port or hostname:port won't be matched.
Now we split the hostname from the hostname:port string, use the correct hostname to do the match.