Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 64-bit atomic operations on 32-bit machines (#19531) #19532

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Fix 64-bit atomic operations on 32-bit machines (#19531) #19532

merged 1 commit into from
Apr 27, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Apr 27, 2022

Fix 64-bit atomic operations on 32-bit machines (go-gitea#19531)
c99ea37 
- Backport go-gitea#19531
  - Doing 64-bit atomic operations on 32-bit machines is a bit tricky by golang, as they can only be done under certain set of conditions(https://pkg.go.dev/sync/atomic#pkg-note-BUG).
  - This PR fixes such case whereby the conditions weren't met, it moves the int64 to the first field of the struct, which will 64-bit operations happening on this property on 32-bit machines.
  - Resolves go-gitea#19518
@Gusted Gusted added this to the 1.16.7 milestone Apr 27, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 27, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2022
@jolheiser jolheiser merged commit 1465e0c into go-gitea:release/v1.16 Apr 27, 2022
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Apr 28, 2022
@fnetX
Fix 64-bit atomic operations on 32-bit machines (go-gitea#19531) (go-…
dc03d44 
…gitea#19532)

- Backport go-gitea#19531
  - Doing 64-bit atomic operations on 32-bit machines is a bit tricky by golang, as they can only be done under certain set of conditions(https://pkg.go.dev/sync/atomic#pkg-note-BUG).
  - This PR fixes such case whereby the conditions weren't met, it moves the int64 to the first field of the struct, which will 64-bit operations happening on this property on 32-bit machines.
  - Resolves go-gitea#19518
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@6543 6543 6543 approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.16.7
Development

Successfully merging this pull request may close these issues.
6 participants
@Gusted @wxiaoguang @6543 @delvh @GiteaBot @jolheiser