Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip TestAPIGitTags temporarily #19509

Closed

Conversation

techknowlogick
Copy link
Member

Related #14247

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 26, 2022
@techknowlogick techknowlogick added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.16 labels Apr 26, 2022
@techknowlogick techknowlogick added this to the 1.17.0 milestone Apr 26, 2022
@zeripath
Copy link
Contributor

zeripath commented Apr 26, 2022

I think this might solve the issue:

diff --git a/integrations/integration_test.go b/integrations/integration_test.go
index 8d2bfe938..228b41237 100644
--- a/integrations/integration_test.go
+++ b/integrations/integration_test.go
@@ -112,6 +112,13 @@ func TestMain(m *testing.M) {
 		}
 	}
 
+	os.Unsetenv("GIT_AUTHOR_NAME")
+	os.Unsetenv("GIT_AUTHOR_EMAIL")
+	os.Unsetenv("GIT_AUTHOR_DATE")
+	os.Unsetenv("GIT_COMMITTER_NAME")
+	os.Unsetenv("GIT_COMMITTER_EMAIL")
+	os.Unsetenv("GIT_COMMITTER_DATE")
+
 	err := unittest.InitFixtures(
 		unittest.FixturesOptions{
 			Dir: filepath.Join(filepath.Dir(setting.AppPath), "models/fixtures/"),

We possibly need to consider unsetting these in Gitea anyway.

@jtran
Copy link
Contributor

jtran commented Apr 26, 2022

I think this might solve the issue:

Yes, we unset these environment variables in our Drone scripts before running unit and integration tests to deal with the issue.

@techknowlogick
Copy link
Member Author

closed in favour of the other PR

@wxiaoguang wxiaoguang removed this from the 1.17.0 milestone Jun 12, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants