Don't panic on ErrEmailInvalid
#19441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't panic on `ErrEmailInvalid`, this was caused due that we were trying to force `ErrEmailCharIsNotSupported` interface, which panics. - Resolves go-gitea#19397
Gusted
added
type/bug
modifies/api
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Apr 20, 2022
- Backport go-gitea#19441 - Don't panic on `ErrEmailInvalid`, this was caused due that we were trying to force `ErrEmailCharIsNotSupported` interface, which panics. - Resolves go-gitea#19397
techknowlogick
approved these changes
Apr 20, 2022
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
Apr 20, 2022
GiteaBot
added
lgtm/done
|
-> #19442 |
Codecov Report
@@ Coverage Diff @@
## main #19441 +/- ##
==========================================
- Coverage 47.40% 47.40% -0.01%
==========================================
Files 951 951
Lines 132327 132333 +6
==========================================
+ Hits 62731 62733 +2
- Misses 62045 62048 +3
- Partials 7551 7552 +1
Continue to review full report at Codecov.
|
zeripath
pushed a commit
that referenced
this pull request
Apr 20, 2022
- Backport #19441 - Don't panic on `ErrEmailInvalid`, this was caused due that we were trying to force `ErrEmailCharIsNotSupported` interface, which panics. - Resolves #19397 Co-authored-by: 6543 <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 21, 2022
* giteaofficial/main: Fix logging of Transfer API (go-gitea#19456) RepoAssignment ensure to close before overwrite (go-gitea#19449) node12 is EOL (go-gitea#19451) Add Changelog v1.16.6 (go-gitea#19339) (go-gitea#19450) Fix DELETE request for non-existent public key (go-gitea#19443) [skip ci] Updated translations via Crowdin Don't panic on `ErrEmailInvalid` (go-gitea#19441)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
- Don't panic on `ErrEmailInvalid`, this was caused due that we were trying to force `ErrEmailCharIsNotSupported` interface, which panics. - Resolves go-gitea#19397
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrEmailInvalid, this was caused due that we were trying to forceErrEmailCharIsNotSupportedinterface, which panics.