Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document 409 error returned by repos/migrate api #19376

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

harryzcy
Copy link
Contributor

The API /repos/migrate could return a 409 Conflict error if a repo with the same name already exists. This pull request document this error code in swagger.

@Gusted
Copy link
Contributor

Gusted commented Apr 11, 2022

Please run make swagger

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 11, 2022
@Gusted Gusted added this to the 1.17.0 milestone Apr 11, 2022
@Gusted Gusted added type/enhancement An improvement of existing functionality modifies/api This PR adds API routes or modifies them and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #19376 (1209dda) into main (d242511) will decrease coverage by 0.09%.
The diff coverage is 42.79%.

@@            Coverage Diff             @@
##             main   #19376      +/-   ##
==========================================
- Coverage   47.51%   47.41%   -0.10%     
==========================================
  Files         944      949       +5     
  Lines      131549   132092     +543     
==========================================
+ Hits        62500    62629     +129     
- Misses      61541    61934     +393     
- Partials     7508     7529      +21     
Impacted Files Coverage Δ
cmd/serv.go 2.33% <0.00%> (-0.06%) ⬇️
models/action.go 48.61% <0.00%> (ø)
models/error.go 36.46% <ø> (-0.03%) ⬇️
models/issue_label.go 68.02% <0.00%> (ø)
models/issue_lock.go 0.00% <0.00%> (ø)
models/issue_project.go 31.70% <0.00%> (ø)
models/pull.go 55.81% <0.00%> (ø)
models/statistic.go 0.00% <0.00%> (ø)
models/unittest/testdb.go 15.50% <0.00%> (-0.13%) ⬇️
modules/convert/pull.go 60.00% <0.00%> (ø)
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3d967...1209dda. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 11, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 12, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 12, 2022
@lunny lunny merged commit f029b9a into go-gitea:main Apr 12, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 12, 2022
* giteaoffical/main:
  Document 409 error returned by repos/migrate api (go-gitea#19376)
  Fix middleware function's placements for some `/user/...` (go-gitea#19377)
  Fix panic in teams API when requesting members (go-gitea#19360)
@harryzcy harryzcy deleted the repo-migrate-409 branch April 12, 2022 18:26
@6543 6543 added the type/docs This PR mainly updates/creates documentation label Jun 18, 2022
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
* Document 409 error returned by repos/migrate api

* Generate swagger spec

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/docs This PR mainly updates/creates documentation type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants