Check go and nodejs version by go.mod and package.json, update Go official site URL

[gesangtome]

Looks like upstream has removed support built
with GO 1.16, the string should be updated here.

[wxiaoguang]

Maybe we can remove the whole go-check and MIN_GO_VERSION, because the go.mod can take the work.

go mod tidy: go.mod file indicates go 1.17, but maximum supported version is 1.16

gitea/go.mod

Line 3 in def5456

go 1.17

[silverwind]

Change is good in any case, it was missed in fe9626a

[silverwind]

Maybe we can remove the whole go-check and MIN_GO_VERSION, because the go.mod can take the work.

I think go.mod is meant to declare the current (e.g. maximum) version, not the minimum one.

[wxiaoguang]

I think go.mod is meant to declare the current (e.g. maximum) version, not the minimum one.

Why? Then why can I compile Gitea with my Go1.18 ..........

[silverwind]

Actually, I'm wrong, it specifies minimum as per https://go.dev/doc/modules/gomod-ref#go, so it might be an option to just parse it out of go.mod, but I think it's material for another PR.

[wxiaoguang]

Why another? Go will report the correct required version automatically by go.mod now, what's the necessary of the old age go-check?

[silverwind]

Will go fail to build if the version is too low? If yes, than we can actually remove the check.

[gesangtome]

Doesn't gitea have a minimum go version requirement?
@silverwind @wxiaoguang

[wxiaoguang]

Doesn't gitea have a minimum go version requirement?

Yes, only the official supported Golang releases (the latest 2 minor versions) are supported.

Will go fail to build if the version is too low? If yes, than we can actually remove the check.

Starting from 1.16, the go build could report correct messages. However, Go 1.15 or older can not report correct messages.

So I think it's fine to remove the go-check, because Go1.15 is quite old now.

And it's also fine to keep the go-check, and maybe the version can be read from the go.mod, then reduce a magic number in Makefile.

$ /usr/local/go-1.16/bin/go build
# code.gitea.io/gitea/modules/hostmatcher
modules/hostmatcher/hostmatcher.go:105:34: ip.IsPrivate undefined (type net.IP has no field or method IsPrivate)
modules/hostmatcher/hostmatcher.go:109:9: ip.IsPrivate undefined (type net.IP has no field or method IsPrivate)
note: module requires Go 1.17

$ /usr/local/go-1.15/bin/go build
../../go/pkg/mod/github.com/caddyserver/[email protected]/filestorage.go:23:2: package io/fs is not in GOROOT (/usr/local/go-1.15/src/io/fs)

[silverwind]

And it's also fine to keep the go-check, and maybe the version can be read from the go.mod, then reduce a magic number in Makefile.

Yes, I support this. Same can be done for node-check as well which defines its minimum version in package.json, but I guess parsing it without additional dependencies will be a bit ugly.

[wxiaoguang]

I updated the go version parsing, and tested locally.

[gesangtome]

And it's also fine to keep the go-check, and maybe the version can be read from the go.mod, then reduce a magic number in Makefile.

Yes, I support this. Same can be done for node-check as well which defines its minimum version in package.json, but I guess parsing it without additional dependencies will be a bit ugly.

Make go-check emit version hints when GO < 1.16?
If yes, we can do this:

diff --git a/Makefile b/Makefile
index 613c08326..5c066fd3b 100644
--- a/Makefile
+++ b/Makefile
@@ -25,7 +25,7 @@ HAS_GO = $(shell hash $(GO) > /dev/null 2>&1 && echo "GO" || echo "NOGO" )
COMMA := ,

XGO_VERSION := go-1.18.x
-MIN_GO_VERSION := 001017000
+MIN_GO_VERSION := 001016000
MIN_NODE_VERSION := 012017000

AIR_PACKAGE ?= github.com/cosmtrek/[email protected]
@@ -205,7 +205,7 @@ help:
go-check:
$(eval GO_VERSION := $(shell printf "%03d%03d%03d" $(shell $(GO) version | grep -Eo '[0-9]+.[0-9.]+' | tr '.' ' ');))
@if [ "$(GO_VERSION)" -lt "$(MIN_GO_VERSION)" ]; then \

•           echo "Gitea requires Go 1.16 or greater to build. You can get it at https://golang.org/dl/"; \
  

•           echo "Sorry, your GO version is too low, Gitea requests an updated GO to build. You can get it at https://golang.org/dl/"; \
            exit 1; \
    fi
  

[wxiaoguang]

@silverwind I also make this PR use the nodejs version from package.json

[silverwind]

May as well extract the third version segment as well because node version is always 3-segments as opposed to go version which is 2.

[wxiaoguang]

It already has the 3-segments. The regex is [0-9.]*

[silverwind]

The line above extracts 2 segments, but this seems to output 3. Is it correct?

[wxiaoguang]

It already has the 3-segments. The regex is [0-9.]*

[silverwind]

Also, I strongly suggest not doing such shell operation on top-level make scope because they will execute whenever the Makefile is invoked which is both wasteful and may produce errors in case when node is absent. It should only be done in eval statements which execute only when the specific target runs.

[wxiaoguang]

Also, I strongly suggest not doing such shell operation on top-level make scope because they will execute whenever the Makefile is invoked which is both wasteful and may produce errors in case when node is absent. It should only be done in eval statements which execute only when the specific target runs.

Moved these lines into go-check and node-check

[gesangtome]

@wxiaoguang @silverwind

Things are going in a good direction, great, looking forward to it being fixed.

[codecov-commenter]

Codecov Report

Merging #19197 (948516d) into main (49c5fc5) will increase coverage by 0.02%.
The diff coverage is 39.03%.

@@            Coverage Diff             @@
##             main   #19197      +/-   ##
==========================================
+ Coverage   46.55%   46.58%   +0.02%     
==========================================
  Files         856      858       +2     
  Lines      123018   123128     +110     
==========================================
+ Hits        57277    57365      +88     
- Misses      58814    58833      +19     
- Partials     6927     6930       +3     

Impacted Files	Coverage Δ
cmd/admin.go	0.00% <0.00%> (ø)
cmd/hook.go	7.11% <0.00%> (ø)
cmd/serv.go	2.39% <0.00%> (ø)
cmd/web_acme.go	0.00% <0.00%> (ø)
models/asymkey/ssh_key_deploy.go	55.55% <ø> (+1.13%)	⬆️
models/helper_environment.go	100.00% <ø> (ø)
modules/context/permission.go	25.39% <0.00%> (ø)
modules/doctor/checkOldArchives.go	22.85% <0.00%> (ø)
modules/doctor/fix16961.go	35.06% <0.00%> (ø)
modules/doctor/mergebase.go	10.25% <0.00%> (ø)
... and 198 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b867d...948516d. Read the comment docs.