Delete related notifications on issue deletion too

[fnetX]

as title

[lunny]

per my comment https://github.com/go-gitea/gitea/pull/18953/files#r816781329

[fnetX]

Hey, I dropped the Action removal (will do this in a separate PR). The only thing left I wanted to do in this PR is to remove the notifications for removed issues.

Please note this is actually a bug I'd either backport that or the whole PR). I thought with #18954 this wouldn't be too weird, but we are facing the bug on Codeberg.

I wonder if I should attempt writing a migration to remove eventual left over notifications. But I'm not sure how migrations can be backported (if at all), because they have a linear counter. If a migration is backported, it probably either shares an id with another important upcoming migration, or increments the counter so that all migrations until then are skipped. Or do I misunderstand the system?

Also note that notifications are also not removed for deleted comments already. I noticed this in the past already, it's a bug on its own (and I'm not going to address this, because I currently can't think of a solution to see if a still needs a notification for the issue (previous post) or has already read the notification. Probably with the issue read state?).

outdated

[6543]

I should attempt writing a migration to remove eventual left over notifications

@fnetX the doctor subcommand is for this ...

[fnetX]

But most people don't run it, do they? Anyway, I'm fine with not bothering. After all, since it's not live for long and not even released yet, it's unlikely many people have clicked the button.

[6543]

well yes - that's why a doctor task would be the best way to do so ... - we can merge this fix first and work in that afterwards

[fnetX]

Oh, by the way, you can remove the backport label again. It's not in 1.16. I was confused about that earlier, too, because it's deployed on Codeberg. (So I'll backport anyway, but not for Gitea).