Fix showing issues in your repositories #18916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make a restriction on which issues can be shown based on if you the
user or team has write permission to the repository.
- Fixes a issue whereby you wouldn't see any associated issues with a
specific team on a organisation if you wasn't a member(fixed by zeroing
the User{ID} in the options).
- Resolves go-gitea#18913
|
I don't think it will ask you have write permissions. We can define what's |
GiteaBot
added
the
lgtm/need 2
|
Yeah the current wording is bad, I've pushed a comment which makes the conditions more clearly. |
Codecov Report
@@ Coverage Diff @@
## main #18916 +/- ##
=======================================
Coverage ? 46.65%
=======================================
Files ? 854
Lines ? 122602
Branches ? 0
=======================================
Hits ? 57196
Misses ? 58514
Partials ? 6892
Continue to review full report at Codecov.
|
Yeah probably, but it seemed to be reproducibly simply. I for myself can test this at latest Monday. |
lunny
reviewed
Feb 27, 2022
fnetX
approved these changes
Feb 27, 2022
lunny
reviewed
Feb 28, 2022
lunny
reviewed
Mar 2, 2022
|
Are you able to fix conflicts? |
|
Luckily not a big conflict. |
zeripath
approved these changes
Mar 23, 2022
GiteaBot
removed
the
lgtm/need 2
GiteaBot
added
the
lgtm/need 1
|
🚀 |
6543
approved these changes
Mar 23, 2022
GiteaBot
added
lgtm/done
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Mar 23, 2022
- Make a restriction on which issues can be shown based on if you the user or team has write permission to the repository.
- Fixes a issue whereby you wouldn't see any associated issues with a specific team on a organization if you wasn't a member(fixed by zeroing the User{ID} in the options).
- Resolves go-gitea#18913
|
-> #19191 |
6543
added a commit
that referenced
this pull request
Mar 23, 2022
- Make a restriction on which issues can be shown based on if you the user or team has write permission to the repository.
- Fixes a issue whereby you wouldn't see any associated issues with a specific team on a organization if you wasn't a member(fixed by zeroing the User{ID} in the options).
- Resolves #18913
Co-authored-by: Gusted <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 24, 2022
* giteaofficial/main: Bump minimist from 1.2.5 to 1.2.6 (go-gitea#19194) Changelog for 1.16.5 (go-gitea#19189) (go-gitea#19192) Fix showing issues in your repositories (go-gitea#18916) Update issue_no_dependencies description (go-gitea#19112) Prevent redirect to Host (2) (go-gitea#19175) Prevent start panic due to missing DotEscape function Fix compare link in active feeds for new branch (go-gitea#19149) Redirect .wiki/* ui link to /wiki (go-gitea#18831) Try to prevent autolinking of displaynames by email readers (go-gitea#19169) Update HTTP status codes to modern codes (go-gitea#18063)
Merged
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
- Make a restriction on which issues can be shown based on if you the user or team has write permission to the repository.
- Fixes a issue whereby you wouldn't see any associated issues with a specific team on a organization if you wasn't a member(fixed by zeroing the User{ID} in the options).
- Resolves go-gitea#18913
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fnetX My local test instance isn't that complex as codeberg's, so I could've missed a edge case. Could you test this PR and see if this fixes the issue?