Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ambiguous column error in organizations page #18314

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

zeripath
Copy link
Contributor

Explicitly set the table for the org_id column queries on the organizations pages.

Fix #18229

Signed-off-by: Andrew Thornton [email protected]

Explicitly set the table for the org_id column queries on the organizations pages.

Fix go-gitea#18229

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels Jan 17, 2022
@zeripath zeripath added this to the 1.16.0 milestone Jan 17, 2022
@zeripath
Copy link
Contributor Author

if merged before #18309 can be skip-changelog

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 17, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@8581e2f). Click here to learn what that means.
The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18314   +/-   ##
=======================================
  Coverage        ?   45.77%           
=======================================
  Files           ?      831           
  Lines           ?    92217           
  Branches        ?        0           
=======================================
  Hits            ?    42214           
  Misses          ?    43244           
  Partials        ?     6759           
Impacted Files Coverage Δ
models/repo_list.go 76.62% <40.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8581e2f...84560fd. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 18, 2022
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 18, 2022
@zeripath zeripath merged commit a7ee4d5 into go-gitea:main Jan 18, 2022
@zeripath zeripath deleted the fix-18229-fix-orgs-dashboard branch January 18, 2022 07:45
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 19, 2022
* giteaoffical/main:
  Restore propagation of ErrDependenciesLeft (go-gitea#18325)
  Fix PR comments UI (go-gitea#18323)
  Make the height of the editor in Review Box smaller (4 lines as GitHub) (go-gitea#18319)
  Fix commit links on compare page (go-gitea#18310)
  Update JS dependencies, remove eslint-plugin-github (go-gitea#18317)
  Add MirrorUpdated field to Repository API type (go-gitea#18267)
  replace satori/go.uuid with gofrs/uuid (go-gitea#18311)
  Place inline diff comment dialogs in the 4th column. (go-gitea#18321)
  Use indirect comparison when showing pull requests (go-gitea#18313)
  Prevent ambiguous column error in organizations page (go-gitea#18314)
  Correctly upload LFS files (go-gitea#18316)
  [skip ci] Updated translations via Crowdin
  update description about vendoring in CONTRIBUTING.md (go-gitea#18280)
  Fix CheckRepoStats and reuse it during migration (go-gitea#18264)
  Minor tweak to tag list (go-gitea#18295)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Explicitly set the table for the org_id column queries on the organizations pages.

Fix go-gitea#18229

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when navigating to an organisations Issue/Pull Request/Milestone page
5 participants