Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json #18283

Merged
merged 1 commit into from
Jan 15, 2022
Merged

Update package-lock.json #18283

merged 1 commit into from
Jan 15, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jan 15, 2022

- NPM didn't like that package-lock.json was out-of-sync, webpack
throwed some errors as well with building.
- Follow-up for: go-gitea#18278
@Gusted Gusted added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 15, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #18283 (0aacc57) into main (aa1e8f6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18283   +/-   ##
=======================================
  Coverage   45.73%   45.73%           
=======================================
  Files         831      831           
  Lines       92164    92164           
=======================================
+ Hits        42152    42154    +2     
  Misses      43249    43249           
+ Partials     6763     6761    -2     
Impacted Files Coverage Δ
modules/queue/workerpool.go 50.00% <0.00%> (-3.06%) ⬇️
models/repo_list.go 77.21% <0.00%> (+0.59%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️
modules/util/remove.go 56.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1e8f6...0aacc57. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2022
@silverwind
Copy link
Member

We should have a check on CI that an npm install does not cause a change in package-lock.json.

@6543 6543 merged commit e239d35 into go-gitea:main Jan 15, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 15, 2022
* 'main' of https://github.com/go-gitea/gitea:
  Update `package-lock.json` (go-gitea#18283)
  Upgrade EasyMDE to 2.16.1 (go-gitea#18278)
  Remove golang vendored directory (go-gitea#18277)
  Changelog for 1.15.10 (go-gitea#18274) (go-gitea#18276)
  Support webauthn (go-gitea#17957)
@silverwind
Copy link
Member

Related: #18285

@Gusted Gusted deleted the update-dev-depdency branch January 15, 2022 18:21
@Gusted
Copy link
Contributor Author

Gusted commented Jan 15, 2022

If someone wants to beat me to it - This needs a backport.

Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
- NPM didn't like that package-lock.json was out-of-sync, webpack
throwed some errors as well with building.
- Follow-up for: go-gitea#18278
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants