Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Pin repositories #17952

Closed
wants to merge 4 commits into from
Closed

[wip] Pin repositories #17952

wants to merge 4 commits into from

Conversation

era
Copy link

@era era commented Dec 10, 2021

Just a placeholder for #10375 MR in order to get feedback as I go with the changes (my first time coding at gitea).

My plan is:

  • Add the fields pinned (boolean) and pinnedOrder (int) to the repo itself, and for now, allow changing these fields with the edit repository API call. I'm not sure if this is the best path or I should create an API just for this.
  • We probably want to limit the number of pinned repositories. Even if we don't use it right now, I think I will code the ability to do it in the backend.

@era era changed the title [wip] Era/10375 [wip] Pin repositories Dec 10, 2021
@era era closed this Dec 11, 2021
@KN4CK3R
Copy link
Member

KN4CK3R commented Dec 14, 2021

I don't think that should be a field of the repo but simply a new table which lists all pinned repos for a user.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 14, 2021
@era
Copy link
Author

era commented Dec 14, 2021

It makes sense to be a new table, I have something working using the new field at: era#1

I will try to make the change to use a new table next week. Thanks for the feedback :)

@r10r
Copy link

r10r commented Jan 10, 2022

Hey @era I just stumbled upon your pull request. Are you still working on this?

@era
Copy link
Author

era commented Jan 12, 2022

No, feel free to pick it up if you have the time :)

@r10r
Copy link

r10r commented Jan 12, 2022

Unfortunately I have no time left right now. But I'll keep an eye on it :)

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants