Update javascript dependencies and upgrade monaco to 0.30.0 #17574
Conversation
Upgrade monaco to 0.30.0 and other javascript dependencies. Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
|
Looks like we may need to back off some more of these dependency changes to get the docker to build |
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
force-pushed
the
monaco-0.30.0
branch
from
6e9088e to
2082f60
Compare
…ough drone" This reverts commit 2082f60.
Signed-off-by: Andrew Thornton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #17574 +/- ##
=======================================
Coverage ? 45.48%
=======================================
Files ? 793
Lines ? 88846
Branches ? 0
=======================================
Hits ? 40415
Misses ? 41916
Partials ? 6515 Continue to review full report at Codecov.
|
| "eslint-plugin-unicorn": "37.0.1", | ||
| "eslint-plugin-vue": "7.19.1", | ||
| "jest": "27.3.0", | ||
| "eslint-plugin-unicorn": "38.0.0", |
There was a problem hiding this comment.
Should add the new rules in .eslintrc, I think both can be enabled, e.g. [2].
There was a problem hiding this comment.
My main point here is get monaco-0.30.0 in as soon as possible. Does this definitely build?
There was a problem hiding this comment.
lint-frontend will fail if the new rules fail, I think it's unlikely that it will.
If you just want to upgrade monaco alone, you could only upgrade it alone, e.g. npm install monaco-editor@latest monaco-editor-webpack-plugin@latest on a fresh branch.
|
More complete PR #17611 that also takes care of one breaking change in Monaco. |
- Update monaco, adapting to breaking changes - Update dropzone, adapting to breaking changes - Update linters, fix new issues, disable opinionated stylelint rules - Rebuild SVGs and images - Tested Dropzone and Monaco Replaces: go-gitea#17574
- Update monaco, adapting to breaking changes - Update dropzone, adapting to breaking changes - Update linters, fix new issues, disable opinionated stylelint rules - Rebuild SVGs and images - Tested Dropzone and Monaco Replaces: #17574
- Update monaco, adapting to breaking changes - Update dropzone, adapting to breaking changes - Update linters, fix new issues, disable opinionated stylelint rules - Rebuild SVGs and images - Tested Dropzone and Monaco Replaces: go-gitea#17574
Upgrade monaco to 0.30.0 and other javascript dependencies.
Signed-off-by: Andrew Thornton [email protected]