Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show client-side error if wiki page is empty #17415

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Show client-side error if wiki page is empty #17415

merged 3 commits into from
Oct 27, 2021

Commits on Oct 24, 2021

  1. fix: show client-side error if wiki page is empty 

    Implement a JS, client-side validation workaround for a bug in the upstream
editor library SimpleMDE which breaks HTML5 client-side validation when
a wiki page is submitted.

This allows native, client-side errors to appear if
the text editor contents are empty.

See upstream bugfix report: sparksuite/simplemde-markdown-editor#324

Signed-off-by: David Jimenez <[email protected]>
    @dvejmz
    dvejmz committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    531311f View commit details
    Browse the repository at this point in the history

  2. refactor: extract variables and minor lint fixes 

    Signed-off-by: David Jimenez <[email protected]>
    @dvejmz
    dvejmz committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    39da7c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Merge branch 'main' into bugfix/17280

    @lafriks
    lafriks authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    d7663c7 View commit details
    Browse the repository at this point in the history