Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repository summary on mobile #17322

Merged
merged 5 commits into from
Oct 17, 2021
Merged

Fix repository summary on mobile #17322

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6947fb
fix: repository summary on mobile
kolaente Oct 15, 2021
db8f121
Merge branch 'main' into fix/repository-summary-mobile
zeripath Oct 15, 2021
e40c101
Merge branch 'main' into fix/repository-summary-mobile
techknowlogick Oct 16, 2021
8e15bc0
Merge branch 'main' into fix/repository-summary-mobile
kolaente Oct 17, 2021
cebbb3c
Merge branch 'main' into fix/repository-summary-mobile
lunny Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions web_src/less/_repository.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2261,17 +2261,20 @@
.list {
width: 100%;
display: flex;
align-items: center;

.item {
width: 100%;
color: var(--color-text);

&:first-of-type {
border-radius: var(--border-radius) 0 0 var(--border-radius);
padding-left: .25rem;
}

&:last-of-type {
border-radius: 0 var(--border-radius) var(--border-radius) 0;
padding-right: .25rem;
}

a {
Expand Down Expand Up @@ -2408,6 +2411,10 @@
border-radius: 0;
user-select: none;

@media @mediaSm {
display: none;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just remove the height of .repository-summary-language-stats, then the language stats bar can be shown correctly.


.bar {
white-space: nowrap;
border: 0;
Expand Down Expand Up @@ -3099,6 +3106,10 @@ td.blob-excerpt {
.repository-summary-language-stats {
height: 48px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we can remove this, then the layout is still correct I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, but the height is set to that magic number for a reason. The comment above that line says prevent page shaking on language bar click and that's the case when removing it.

overflow: hidden;

@media @mediaSm {
height: auto;
}
}

.ui.form .right .ui.button {
Expand Down