AutoRegistration is supposed to be working with disabled registration #17219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
approved these changes
Oct 7, 2021
GiteaBot
added
the
lgtm/need 1
wxiaoguang
approved these changes
Oct 11, 2021
GiteaBot
added
lgtm/done
lafriks
approved these changes
Oct 11, 2021
|
We should have an option for every auth source if it allows auto registration. |
|
@kvaster thanks for the PR, could you send a backport PR for this to the release/v1.15 branch? |
Will do it tomorrow. |
kvaster
added a commit
to kvaster/gitea
that referenced
this pull request
Oct 11, 2021
techknowlogick
pushed a commit
that referenced
this pull request
Oct 12, 2021
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Oct 15, 2021
…go-gitea#17219) Co-authored-by: 6543 <[email protected]> Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto registration is broken currently with this PR: #15795
Auto registration should be working even if standard registration is disabled. Common use of auto registration is when we have trusted auth provider (openid, google e.t.c.) and all other types of registration are disabled.