DBContext is just a Context #17100
Merged
DBContext is just a Context #17100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes some of the specialness from the DBContext and makes it context This allows us to simplify the GetEngine code to wrap around any context in future and means that we can change our loadRepo(e Engine) functions to simply take contexts. Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
the
type/refactoring
|
unit tests fail |
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #17100 +/- ##
=======================================
Coverage 45.31% 45.31%
=======================================
Files 773 773
Lines 86873 86907 +34
=======================================
+ Hits 39366 39382 +16
- Misses 41151 41163 +12
- Partials 6356 6362 +6
Continue to review full report at Codecov.
|
KN4CK3R
reviewed
Sep 22, 2021
KN4CK3R
reviewed
Sep 22, 2021
Comment on lines
+26
to
+31
| stats.Counter.PublicKey, _ = db.GetEngine(db.DefaultContext).Count(new(PublicKey)) | ||
| stats.Counter.Repo = CountRepositories(true) | ||
| stats.Counter.Watch, _ = db.DefaultContext().Engine().Count(new(Watch)) | ||
| stats.Counter.Star, _ = db.DefaultContext().Engine().Count(new(Star)) | ||
| stats.Counter.Action, _ = db.DefaultContext().Engine().Count(new(Action)) | ||
| stats.Counter.Access, _ = db.DefaultContext().Engine().Count(new(Access)) | ||
| stats.Counter.Watch, _ = db.GetEngine(db.DefaultContext).Count(new(Watch)) | ||
| stats.Counter.Star, _ = db.GetEngine(db.DefaultContext).Count(new(Star)) | ||
| stats.Counter.Action, _ = db.GetEngine(db.DefaultContext).Count(new(Action)) | ||
| stats.Counter.Access, _ = db.GetEngine(db.DefaultContext).Count(new(Access)) |
There was a problem hiding this comment.
Could introduce a variable to reduce the calls.
There was a problem hiding this comment.
As you might imagine, the code was a result of a mass find and replace.
There was a problem hiding this comment.
Sure, but could be changed while working at it.
KN4CK3R
approved these changes
Sep 22, 2021
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Sep 23, 2021
GiteaBot
added
lgtm/done
|
Please resolve the conflicts. |
Signed-off-by: Andrew Thornton <[email protected]>
|
make lgtm work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some of the specialness from the DBContext and makes it context
This allows us to simplify the GetEngine code to wrap around any context in future
and means that we can change our loadRepo(e Engine) functions to simply take contexts.
Signed-off-by: Andrew Thornton [email protected]