Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent NPE in CSV diff rendering when column removed #17018

Merged
merged 22 commits into from
Oct 20, 2021
Merged

Prevent NPE in CSV diff rendering when column removed #17018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
df216fd
Fixes #16837 - CSV column diff error
richmahn Sep 11, 2021
2016455
Reworks CSV diff
richmahn Sep 12, 2021
81799d2
Fixes tests
richmahn Sep 12, 2021
58a059a
Fixes linting
richmahn Sep 12, 2021
b510356
Fixes linting
richmahn Sep 12, 2021
5abe681
Better variable names and camelcase
richmahn Sep 12, 2021
8dadb94
Merge remote-tracking branch 'origin/main' into richmahn-16837-csv-co…
richmahn Sep 12, 2021
9f70afe
moves checking for EOF in the csv Renderer
Sep 12, 2021
aa526e5
Fixes EOF problem
richmahn Sep 13, 2021
01671aa
Better error handling and knowing if cell exists
richmahn Sep 14, 2021
535a86c
Fixes tests
richmahn Sep 14, 2021
5f24d14
Merge remote-tracking branch 'origin/main' into richmahn-16837-csv-co…
richmahn Sep 14, 2021
0708733
removes io.EOF check for ioutil.ReadAll()
richmahn Sep 14, 2021
ba85dfd
Better EOF handling
richmahn Sep 14, 2021
99ac2b7
Refactor of CSV column diff
richmahn Sep 23, 2021
8707f21
Better looping so no diff table copying
richmahn Sep 24, 2021
aa79ce2
Merge remote-tracking branch 'origin/main' into richmahn-16837-csv-co…
richmahn Oct 6, 2021
1d7a519
Properly handle where to put the a rows
richmahn Oct 6, 2021
480d9ec
Updates tests
richmahn Oct 19, 2021
fe1bbc6
Fixes typos
richmahn Oct 19, 2021
131992a
Merge branch 'main' into richmahn-16837-csv-column-diff-error
jolheiser Oct 19, 2021
ea6e9bc
Merge branch 'main' into richmahn-16837-csv-column-diff-error
zeripath Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/csv/csv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ func CreateReaderAndGuessDelimiter(rd io.Reader) (*stdcsv.Reader, error) {
var data = make([]byte, 1e4)
size, err := rd.Read(data)
if err != nil {
if err == io.EOF {
return CreateReader(bytes.NewReader([]byte{}), rune(',')), nil
}
return nil, err
}

Expand Down
Loading