Add setting to OAuth handlers to skip local 2FA authentication #16594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
reviewed
Aug 1, 2021
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## main #16594 +/- ##
=======================================
Coverage 45.19% 45.19%
=======================================
Files 762 762
Lines 86173 86179 +6
=======================================
+ Hits 38942 38949 +7
+ Misses 40935 40931 -4
- Partials 6296 6299 +3
Continue to review full report at Codecov.
|
lafriks
approved these changes
Aug 1, 2021
GiteaBot
added
lgtm/need 1
This PR adds a setting to OAuth and OpenID login sources to allow the source to override local 2FA requirements. Fix go-gitea#13939 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
force-pushed
the
fix-13939-make-2fa-optional
branch
from
59a58de
to
ceaf11c
Compare
This was referenced Aug 21, 2021
Closed
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
changed the title
6543
approved these changes
Sep 10, 2021
GiteaBot
added
lgtm/done
|
🚀 |
zeripath
added a commit
that referenced
this pull request
Sep 17, 2021
This PR extends #16594 to allow LDAP to be able to be set to skip local 2FA too. The technique used here would be extensible to PAM and SMTP sources. Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a setting to OAuth and OpenID login sources to allow the source to
skip local 2FA authentication.
Fix #13939
Signed-off-by: Andrew Thornton [email protected]