Fix crash following ldap authentication update (#16447) #16449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport go-gitea#16447 Unfortunately go-gitea#16268 contained a terrible error, whereby there was a double indirection taken when unmarshalling the source data. This fatally breaks authentication configuration reading. Fix go-gitea#16342 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/bug
issue/critical
lafriks
approved these changes
Jul 15, 2021
GiteaBot
added
the
lgtm/need 1
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jul 15, 2021
Once go-gitea#16449 is merged I think we should release 1.14.5. There are a couple of security fixes and the broken go-gitea#16268 is annoying enough that we should just release things. Signed-off-by: Andrew Thornton <[email protected]>
Merged
techknowlogick
approved these changes
Jul 16, 2021
GiteaBot
added
lgtm/done
zeripath
added a commit
that referenced
this pull request
Jul 16, 2021
Once #16449 is merged I think we should release 1.14.5. There are a couple of security fixes and the broken #16268 is annoying enough that we should just release things. Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #16447
Unfortunately #16268 contained a terrible error, whereby there was a double
indirection taken when unmarshalling the source data. This fatally breaks
authentication configuration reading.
Fix #16342
Signed-off-by: Andrew Thornton [email protected]