add configuration option to restrict users by default #16256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting this in the model messes with other workflows (e.g. syncing LDAP users) where the IsRestricted permission needs to be explicitly set and not overridden by a config value
Codecov Report
@@ Coverage Diff @@
## main #16256 +/- ##
==========================================
+ Coverage 44.24% 45.49% +1.25%
==========================================
Files 695 709 +14
Lines 82341 83743 +1402
==========================================
+ Hits 36429 38099 +1670
+ Misses 40014 39510 -504
- Partials 5898 6134 +236
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
adelowo
reviewed
Jul 4, 2021
adelowo
approved these changes
Jul 5, 2021
GiteaBot
added
lgtm/need 1
6543
reviewed
Jul 6, 2021
6543
reviewed
Jul 6, 2021
6543
reviewed
Jul 6, 2021
6543
approved these changes
Jul 6, 2021
GiteaBot
added
lgtm/done
|
🚀 |
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
* add configuration option to restrict users by default * default IsRestricted permission only set on sign up setting this in the model messes with other workflows (e.g. syncing LDAP users) where the IsRestricted permission needs to be explicitly set and not overridden by a config value * fix formatting * Apply suggestions from code review * ensure newly created user is set to restricted * ensure imports are in the correct order Co-authored-by: 6543 <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #427.
Adds a configuration option to app.ini that makes new users have the
IsRestrictedpermission set totrueby default.