Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade unrolled/render to v1.1.1 #15845

Merged
merged 2 commits into from
May 12, 2021
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented May 12, 2021

As title.

Fix #15832

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 12, 2021
@zeripath
Copy link
Contributor

zeripath commented May 12, 2021

Please note there's still a bug in unrolled/render that unrolled/render#91 & unrolled/render#92 would fix - (I missed noticing that TemplateLookup wasn't being locked properly prior to unrolled/render#90). This bug should only affect IsDevelopment mode so it's minor.

I need one of 91 or 92 to be chosen before I can make the development mode cleaner.


Scratch that I've chosen 92 and closed 91 - so that 93 can work too.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 12, 2021
@6543
Copy link
Member

6543 commented May 12, 2021

Lets backport this since it fix a critical isssue

@zeripath zeripath merged commit b61092b into go-gitea:main May 12, 2021
zeripath pushed a commit to zeripath/gitea that referenced this pull request May 12, 2021
@zeripath zeripath added the backport/done All backports for this PR have been created label May 12, 2021
6543 pushed a commit that referenced this pull request May 12, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@lunny lunny deleted the lunny/upgrade_render branch August 24, 2023 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since Chi migration html rendering is essentially single threaded due to unrolled
6 participants