Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken avatars since #15301 #15731

Merged
merged 2 commits into from
May 5, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 5, 2021

There was a missing * from the avatars routes in #15301.

Fix #15727

Signed-off-by: Andrew Thornton [email protected]

There was a missing * from the avatars routes in go-gitea#15301.

Fix go-gitea#15727

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels May 5, 2021
@zeripath zeripath added this to the 1.15.0 milestone May 5, 2021
@silverwind
Copy link
Member

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf maybe you can confirm this.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 5, 2021
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf maybe you can confirm this.

on it

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

thanks @zeripath && @silverwind , this definitely fixes #15727 🚀
user-supplied user avatars: shown ✔️
org gravatars: shown ✔️
user-supplied repo avatars (those were missing, too :D): shown ✔️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 5, 2021
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath
Copy link
Contributor Author

zeripath commented May 5, 2021

I've added a testcase to ensure that user Avatars don't break again (at least not in the same way.)

@zeripath
Copy link
Contributor Author

zeripath commented May 5, 2021

make lgtm work

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2021
@zeripath zeripath merged commit eed88dc into go-gitea:main May 5, 2021
@zeripath zeripath deleted the fix-15727-broken-org-avatars branch May 5, 2021 13:06
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 5, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
There was a missing * from the avatars routes in go-gitea#15301.

Fix go-gitea#15727

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatars missing after recent upgrade (47fd15693)
6 participants