-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump unrolled/render to v1.1.0 #15581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.1.0 has improved buffer pooling
lunny
approved these changes
Apr 22, 2021
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Apr 22, 2021
zeripath
approved these changes
Apr 22, 2021
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 22, 2021
@nsmith5 can you send a backport to v1.14. If you need help just ask :) |
@6543 yeah absolutely. Is there a release branch or something I need to target for v.1.14? |
@nsmith5 yes -> just cherry-pick the squashed commit and create a pull targeting |
@nsmith5 the below is my script for creating backports quickly. #!/bin/sh
PR="$1"
SHA="$2"
VERSION="$3"
if [ -z "$SHA" ]; then
SHA=$(gh api /repos/go-gitea/gitea/pulls/$PR -q '.merge_commit_sha')
fi
if [ -z "$VERSION" ]; then
VERSION="v1.14"
fi
echo git checkout origin/release/"$VERSION" -b backport-$PR-$VERSION
git checkout origin/release/"$VERSION" -b backport-$PR-$VERSION
git cherry-pick $SHA && git commit --amend && git push zeripath backport-$PR-$VERSION && xdg-open https://github.com/go-gitea/gitea/compare/release/"$VERSION"...zeripath:backport-$PR-$VERSION |
Backported here #15608 |
techknowlogick
added
the
backport/done
All backports for this PR have been created
label
Apr 24, 2021
lunny
pushed a commit
that referenced
this pull request
Apr 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
performance/memory
Performance issues affecting memory use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unrolled/render
is used to render content. For HTML templates, it uses a buffer pool. A buffer must be used when HTML templating to check for templating errors before writing content to the response writer (because the first write will implicitly set the status to 200 if not already set).In versions <= v1.0.3 the buffer pool used was set to 64 buffers that could grow indefinitely. In practice this would lead to 64 * the largest template size in memory usage. In v1.1.0, the buffer pool is configurable, but defaults to a more reasonable 32 * 512KiB buffers. Instead of growing indefinitely, buffers are garbage collected if they grow pasted the 512KiB limit. This means the buffer pool has a fixed cost of 16MiB.
Further details and profiling results can be seen in the pull request upstream : unrolled/render#87