[refactor] Unify the export of user data via API #15144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
type/refactoring
lafriks
approved these changes
Mar 25, 2021
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Mar 27, 2021
There was a problem hiding this comment.
Generally go prefers the context of an operation to be the first argument to a function - which would suggest that the doer should be the first argument - however, I can see how confusing that would be.
My suspicion is that instead of passing round a *models.User as the doer it should be some kind of context (this could even be a context.Context which just gets cast as a grant/permission context or uses GetValue(...) to get the grant/permission context from it) which expresses the permissions complex for actions - however, we do no have a consistent system for this kind of thing at present.
Therefore I approve this as it is clearly less confusing than our current crap.
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this make sure no private information is leaked by accident
close #14446