Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 500 on pull view page if user is not loged in (#14885) #14886

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Fix 500 on pull view page if user is not loged in (#14885) #14886

merged 1 commit into from
Mar 4, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 4, 2021

backport #14885

  • IsUserAllowedToUpdate should igonre if user is nil

@6543 6543 added the type/bug label Mar 4, 2021
@6543 6543 added this to the 1.13.4 milestone Mar 4, 2021
@6543 6543 changed the title IsUserAllowedToUpdate should igonre if user is nil Fix 500 on pull view page if user is not loged in (#14885) Mar 4, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 4, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2021
@6543 6543 merged commit 8a6acbb into go-gitea:release/v1.13 Mar 4, 2021
@6543 6543 deleted the backport_14885_fix_nil-exeption-in-pull-view branch March 4, 2021 20:28
@6543 6543 mentioned this pull request Mar 5, 2021
Merged
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@noerw noerw noerw approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.4
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @noerw @jolheiser @GiteaBot