Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Release attachments replace if name exist #13750

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 29, 2020

close #10919
close #9534

TODO:

@6543 6543 added the type/enhancement An improvement of existing functionality label Nov 29, 2020
@6543 6543 added this to the 1.14.0 milestone Nov 29, 2020
@codecov-io
Copy link

Codecov Report

Merging #13750 (5d49b7b) into master (e8a6c42) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13750      +/-   ##
==========================================
- Coverage   42.23%   42.12%   -0.12%     
==========================================
  Files         699      699              
  Lines       76957    76957              
==========================================
- Hits        32506    32418      -88     
- Misses      39094    39196     +102     
+ Partials     5357     5343      -14     
Impacted Files Coverage Δ
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/notification/ui/ui.go 84.72% <0.00%> (-11.12%) ⬇️
models/issue_comment.go 43.50% <0.00%> (-9.22%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
modules/notification/mail/mail.go 33.33% <0.00%> (-5.75%) ⬇️
modules/git/commit.go 49.67% <0.00%> (-3.95%) ⬇️
modules/notification/base/null.go 74.28% <0.00%> (-2.86%) ⬇️
modules/notification/notification.go 83.92% <0.00%> (-2.68%) ⬇️
services/pull/check.go 48.90% <0.00%> (-2.19%) ⬇️
models/error.go 38.17% <0.00%> (-1.31%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a6c42...5d49b7b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 29, 2020
@lunny lunny modified the milestones: 1.14.0, 1.x.x Jan 27, 2021
@noerw noerw added the pr/wip This PR is not ready for review label May 14, 2021
@stale stale bot added the issue/stale label Jul 21, 2021
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jul 21, 2021
@stale stale bot removed the issue/stale label Jul 21, 2021
@go-gitea go-gitea deleted a comment from stale bot Jul 21, 2021
@mxmehl
Copy link

mxmehl commented Nov 2, 2021

Is this blocked by something? Would be great to have predictable/human-readable URLs again which are also shown in the UI, and do not have to be guessed :)

@6543
Copy link
Member Author

6543 commented Nov 15, 2021

yes backend and frontend need changes see checkbox of this pull :/

@jolheiser
Copy link
Member

fwiw I'm fine with moving the remaining TODOs to another PR.

@lunny lunny removed this from the 1.x.x milestone Jan 18, 2023
@wxiaoguang
Copy link
Contributor

It has been fixed by

@wxiaoguang wxiaoguang closed this May 10, 2023
@6543 6543 deleted the release-attachments_reject-duplicate-names branch May 10, 2023 21:37
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. pr/wip This PR is not ready for review type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] replace attachment when same name on uplaod Attachment links are not human readable again
8 participants