Add left padding for chunk header of split diff view

[bagasme]

This commit adds 10px padding-left on chunk header element
(which is <span>).

For example (taken from commit 06268dc):

Without padding, the chunk header looks less neat:

Signed-off-by: Bagas Sanjaya [email protected]

[codecov-io]

Codecov Report

Merging #13397 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13397      +/-   ##
==========================================
- Coverage   42.13%   42.13%   -0.01%     
==========================================
  Files         691      691              
  Lines       75968    75968              
==========================================
- Hits        32010    32009       -1     
- Misses      38710    38714       +4     
+ Partials     5248     5245       -3     

Impacted Files	Coverage Δ
services/pull/temp_repo.go	26.59% <0.00%> (-3.20%)	⬇️
services/pull/patch.go	53.97% <0.00%> (-1.71%)	⬇️
modules/queue/workerpool.go	58.77% <0.00%> (-1.23%)	⬇️
services/pull/pull.go	41.27% <0.00%> (+0.49%)	⬆️
modules/git/repo.go	46.70% <0.00%> (+0.50%)	⬆️
services/pull/check.go	49.63% <0.00%> (+0.72%)	⬆️
modules/git/utils.go	77.04% <0.00%> (+3.27%)	⬆️
modules/indexer/stats/db.go	60.86% <0.00%> (+8.69%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06268dc...9d59019. Read the comment docs.

[silverwind]

Could also use the helper class pl-3 for similar effect without any CSS needed:

gitea/web_src/less/helpers.less

Line 65 in 06268dc

.pl-3 { padding-left: .5rem !important; }

Thought I guess you really want px-3 to pad both sides for symmetry:

gitea/web_src/less/helpers.less

Line 93 in 06268dc

.px-3 { padding-left: .5rem !important; padding-right: .5rem !important; }

[bagasme]

@silverwind I'd tried your suggestion at commit bagasme/gitea@adda0dc.
Unfortunately, the resulting HTML after building does not change (the px-3 class is stripped away), despite that I'd cleared browser cache and doing make clean-all before build.

[silverwind]

Try make clean-all followed by a make watch. There's no cache involved for HTML so it should always be fresh.

[bagasme]

@silverwind I still can't get the px-3 class to appear on <span> chunk header element, and thus the padding.

[silverwind]

Will try later. Unless there is JS that overrides it, I see no reason why it shouldn't work.

[silverwind]

Where is that header seen? I thought it was diff but it seems that one has enought whitespace on the left side I think:

[bagasme]

@silverwind that was what I mean for this PR

[silverwind]

Isn't there enought whitespace already (added by unremovable .lines-type-marker):

[mrsdizzie]

Hm seems like the screenshot in the PR description is misleading and has intentionally cropped out the existing whitespace from .lines-type-marker to the left then? I agree with @silverwind this seems to look OK already unless there is a misunderstanding of why changing it would be better. Looks about the same as Github now except they use @@ to start the line

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

[zeripath]

@mrsdizzie I've been able to replicate what @bagasme was seeing and I've fixed up this PR.

I think this is now ready for merge.

[codecov-commenter]

Codecov Report

Merging #13397 (51f4792) into main (d04e581) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #13397   +/-   ##
=======================================
  Coverage   45.25%   45.26%           
=======================================
  Files         771      771           
  Lines       86767    86767           
=======================================
+ Hits        39264    39272    +8     
+ Misses      41148    41140    -8     
  Partials     6355     6355           

Impacted Files	Coverage Δ
modules/queue/queue_disk_channel.go	60.94% <0.00%> (-1.78%)	⬇️
services/pull/pull.go	41.78% <0.00%> (-0.41%)	⬇️
modules/queue/workerpool.go	47.70% <0.00%> (+0.38%)	⬆️
models/issue_comment.go	51.76% <0.00%> (+0.58%)	⬆️
services/repository/transfer.go	56.60% <0.00%> (+1.88%)	⬆️
modules/process/manager.go	75.30% <0.00%> (+2.46%)	⬆️
modules/git/utils.go	70.83% <0.00%> (+2.77%)	⬆️
modules/git/repo_base_nogogit.go	85.71% <0.00%> (+2.85%)	⬆️
modules/queue/queue_channel.go	95.00% <0.00%> (+3.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d04e581...51f4792. Read the comment docs.