Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog for v1.12.6 #13152

Merged
merged 10 commits into from
Nov 16, 2020
Merged

Changelog for v1.12.6 #13152

merged 10 commits into from
Nov 16, 2020

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Oct 15, 2020

We should release final 1.12.x version before we release 1.13.0

@lafriks lafriks added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 15, 2020
@lafriks lafriks added this to the 1.12.6 milestone Oct 15, 2020
techknowlogick
techknowlogick reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably wait to release 1.12.6 until 1.13.0 is ready, just in case any backports are needed.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 15, 2020
@lafriks
Copy link
Member Author

lafriks commented Oct 15, 2020 •
edited
Loading

I don't think there will be such critical issues that can not wait for 1.13.0, imho :) @zeripath 😝

@zeripath
Copy link
Contributor

Sorry!

@zeripath
Copy link
Contributor

Just sharing the love of and pain I feel for our diff infrastructure

@zeripath
Copy link
Contributor

For anyone else reading we're referring to #13157

@lafriks
Copy link
Member Author

lafriks commented Oct 15, 2020

yeah... third rewrite if I counted right in few weeks :D

@zeripath
Copy link
Contributor

Well this one is a complete rewrite of ParsePatch - others were bodges because I didn't want to have to rewrite it.

We should actually rewrite at least once more though with a proper AST structure and potentially to a pure streaming structure although that won't be backportable.

@ratuka
Copy link

ratuka commented Oct 27, 2020

Is anything happen on this branch?

@lafriks
Copy link
Member Author

lafriks commented Oct 27, 2020

Waiting for one more PR to be merged

6543
6543 reviewed Oct 30, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
6543
6543 approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ just update above and I think it's time ...

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2020
@lafriks
Copy link
Member Author

lafriks commented Oct 30, 2020

Nope, one more issue should be fixed

@lafriks lafriks added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Oct 30, 2020
@6543
Copy link
Member

6543 commented Oct 30, 2020

@lafriks witch one is it?

@lafriks
Copy link
Member Author

lafriks commented Oct 31, 2020

Not created yet, working on it :)

@ratuka
Copy link

ratuka commented Nov 11, 2020

Not created yet, working on it :)

nice, but when will be available?

@lafriks lafriks removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Nov 11, 2020
@lafriks
Copy link
Member Author

lafriks commented Nov 11, 2020

It was not that important as I initially thought so it can also be included just in 1.13.0 final

6543
6543 requested changes Nov 11, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 11, 2020
zeripath
zeripath previously requested changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to include #13525

6543
6543 reviewed Nov 11, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@lafriks
Copy link
Member Author

lafriks commented Nov 11, 2020

@zeripath done

@6543 6543 requested a review from zeripath November 11, 2020 22:35
6543
6543 reviewed Nov 11, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Nov 12, 2020

Maybe wait for an extra PR? @lafriks

@lafriks
Copy link
Member Author

lafriks commented Nov 12, 2020

What PR?

@a1012112796
Copy link
Member

What PR?

#13527

@zeripath zeripath dismissed their stale review November 12, 2020 17:40

outdated

6543
6543 reviewed Nov 14, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@6543 6543 added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Nov 16, 2020
@lafriks
Copy link
Member Author

lafriks commented Nov 16, 2020

@zeripath ping

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2020
@lunny lunny merged commit 53b89c3 into go-gitea:release/v1.12 Nov 16, 2020
@lunny
Copy link
Member

lunny commented Nov 16, 2020

Oh, I accidentally merged this.

@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@6543 6543 6543 approved these changes

@zeripath zeripath Awaiting requested review from zeripath

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.12.6
Development

Successfully merging this pull request may close these issues.
8 participants
@lafriks @zeripath @ratuka @6543 @lunny @a1012112796 @techknowlogick @GiteaBot