-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repository create/delete event webhooks #13008
Merged
zeripath
merged 2 commits into
go-gitea:master
from
jamesorlakin:bugfix/webhookRepoDeletionCreation
Oct 2, 2020
Merged
Fix repository create/delete event webhooks #13008
zeripath
merged 2 commits into
go-gitea:master
from
jamesorlakin:bugfix/webhookRepoDeletionCreation
Oct 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Oct 1, 2020
zeripath
approved these changes
Oct 1, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Oct 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #13008 +/- ##
==========================================
+ Coverage 42.58% 42.62% +0.03%
==========================================
Files 671 671
Lines 73632 73629 -3
==========================================
+ Hits 31358 31381 +23
+ Misses 37188 37168 -20
+ Partials 5086 5080 -6
Continue to review full report at Codecov.
|
CirnoT
approved these changes
Oct 2, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Oct 2, 2020
Does this want a backport? |
jamesorlakin
added a commit
to jamesorlakin/gitea
that referenced
this pull request
Oct 4, 2020
techknowlogick
added
the
backport/done
All backports for this PR have been created
label
Oct 4, 2020
7 tasks
techknowlogick
pushed a commit
that referenced
this pull request
Oct 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR changes the webhook trigger behaviour to be more in line with what's expected. (When 'repository' events are enabled, of course)
In other words:
In order to enable the latter the webhook has to now be triggered before the actual repo undergoes deletion. I'm willing to tweak this to try and 'grab' the webhook model beforehand and trigger the webhook notifier directly afterwards, but this may make the code more complex for little benefit.
Closes #11766, #9180.